Re: patch to append files to playlist

On Fri, 3 Dec 2004, Morten Nilsen wrote:

> when the new binary is started, it reads the config and sees the
> original state, thus, it assumes not to append, and tells the old
> process to replace it's playlist with the specified file(s)

exactly

> I see 3 solutions;
> 
> 1) force xmms to save config when checkbox changes

Shouldn't be necessary, any sane program should be able to work with its 
options in memory and only have to save them to disk when asked to or upon 
exit.

> 2) move the option away from the dropdown (into prefs) and put a notice
> that changes require restart

Shouldn't be necessary either, restarting to update config options (like 
this one anyway) isn't intuitive at all. Any decent GUI toolkit should 
provide the callback functionality necessary to do what we need here.

> 3) change the architecture such that the enqueue/replace decision is
> made in the running xmms, not the new instance.

Don't know what you mean by 'architecture.'

A simple callback should be all that's needed. Ie:

User checks or un-checks 'Append to playlist' option, Upon the state 
change callback function is called to update config variable in memory to 
reflect the new state

Simple as that - atleast for someone who knows the GTK toolkit. ;-)

-- Cal