Re: 32bit pcm and float support in .wav Input plugin

Håvard Kvålen <[email protected]> Wed, 12 Jan 2005 22:35:43 +0100 (CET)
Newsgroups gmane.comp.multimedia.xmms.devel
Message-ID <[email protected]>
On Wed, 22 Dec 2004, Dirk Jagdmann wrote:

> If you include this into the next relase of xmms, then you can safely
> delete the wav.h file, as it no longer contains any code this patched
> plugin needs.

This patch has been commited to cvs.  Thanks!

This patch was, however, not 64 bit clean.  In particular you cannot
depend on 'long' beeing 32 bits.  One should use one of the glib types
with specific size, i.e. guint32 when you depend on a variable beeing of a
specific size.

Did you test 12 bits files?  They seem to be broken to me.

 - Håvard