Re: [PATCH] - improved decoding of URL special characters

On Wed, Oct 19, 2005 at 04:20:37PM -0500, Dustin Kirkland wrote:
> I think it's a matter of taste, and I don't particularly care if my
> patch or yours (I assume a patch would come along) were eventually
> accepted.  I'd just like to see this functionality at some point in
> the mainline xmms ;)

You're right, it really doesn't matter.  I just thought I'd throw my two cents
in.

To be honest I'm a bit too occupied at the moment to come up with a patch and
try it out.

I guess it didn't show up in your test but the point about performance is that
it would appear that, let's say the string was %ff%ff%ff%ff%ff etc.  If I am
reading it correctly, your version would take the first %ff, put the byte 255
at the beginning, and move the rest of the string to the start, then do the
whole thing over again for the next %ff, copying the remaining portion of the
string again and again.  Mine loops through the characters exactly once
regardless of input.

But again, in practical terms it's not noticable.  Maybe I'm reading your code
wrong, even.

Andrew