Re: [PATCH] - further improved decoding of URL special characters

This is a multi-part message in MIME format.
--------------050205030403000306030205
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Morten Nilsen wrote:
> int char2int( char ch )
> {
> 	short n = ch & 0xf;

<snip>

> void urldecodestr( char *buf )
> {
> 	const char *r = buf;
> 	char b, c;
> 	while( *r ) {

<snip>

it just occured to me it would probably be better to do call the support 
function hexdecode, and use signed char for the intermediate variables..
updated .c attached

Cheers,
-- 
Morten

--------------050205030403000306030205
Content-Type: text/plain;
 name="urldecode.c"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
 filename="urldecode.c"

c2lnbmVkIGNoYXIgaGV4ZGVjb2RlKCBjaGFyIGNoICkKewoJc2lnbmVkIGNoYXIgbiA9IGNo
ICYgMHhmOwoJc3dpdGNoKGNoID4+IDQpCgl7CgkJY2FzZSA0OiAvLyBVcHBlcmNhc2UgbGV0
dGVyCgkJY2FzZSA2OiAvLyBMb3dlcmNhc2UgbGV0dGVyCgkJCW4gKz0gOTsKCQkJaWYobiA8
IDEwIHx8IG4gPiAxNSkKCQkJCW4gPSAtMTsgCgkJY2FzZSAzOiAvLyBOdW1iZXIKCQkJYnJl
YWs7CgkJZGVmYXVsdDoKCQkJbiA9IC0xOwoJfQoJcmV0dXJuIG47Cn0KCnZvaWQgdXJsZGVj
b2Rlc3RyKCBjaGFyICpidWYgKQp7Cgljb25zdCBjaGFyICpyID0gYnVmOwoJc2lnbmVkIGNo
YXIgYiwgYzsKCXdoaWxlKCAqciApIHsKCQlpZigqciA9PSAnJScpIHsKCQkJYiA9IGhleGRl
Y29kZShyWzFdKTsKCQkJYyA9IGhleGRlY29kZShyWzJdKTsKCQkJaWYoYiA+PSAwICYmIGMg
Pj0gMCkgewoJCQkJciArPSAzOwoJCQkJKmJ1ZisrID0gKGIgPDwgNCkgfCBjOwoJCQkJY29u
dGludWU7CgkJCX0KCQl9CgkJKmJ1ZisrID0gKnIrKzsKCX0KCSpidWYgPSAwOwp9Cg==
--------------050205030403000306030205
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
xmms-devel mailing list
[email protected]
http://lists.xmms.org/mailman/listinfo/xmms-devel

--------------050205030403000306030205--