suggested patch to cmdline --pause
"Rick C. Petty" <[email protected]> Mon, 20 Mar 2006 17:03:45 -0600
| Newsgroups | gmane.comp.multimedia.xmms.devel |
|---|---|
| Message-ID | <[email protected]> |
Hello. XMMS is powerful because of its command-line control. However, I dislike the semantic of how --pause works. Currently, specifying --pause just effectively toggles the pause button and there is no semantic for saying "pause, no matter what". Since the command --play-pause is quite similar in that it starts or pauses playback, I propose that the --pause be changed to "pause, no matter whether it was previously paused". I realize that technically, there is a difference between "start or pause" and "pause or unpause", I believe that script writers want a --pause which performs a pause instead of toggling, sort of like how --play will restart playback regardless of whether the session was already playing. I've attached a patch (against xmms-1.2.10) for the --pause command. This patch turns the command-line "--pause" into a "pause, no matter what". It does not change the behavior of the GUI control for toggling a pause, nor should it change the behavior of plugins who rely upon the toggling effect. Please consider and apply this patch. As it currently stands, there is no way for me to have a window-manager key command that locks the screen and also pauses xmms playback-- if playback is already paused, my lock command will resume playback. I don't think this is desirable. Please contact me directly, I'm not on the list. Thank you, -- Rick C. Petty