Re: [PATCH] Free OSS device on pause
"Metathronius Galabant" <[email protected]> Tue, 10 Oct 2006 11:47:18 +0200
| Newsgroups | gmane.comp.multimedia.xmms.devel |
|---|---|
| Message-ID | <[email protected]> |
> > please consider the following trivial patch for 1.2.11 (if there will be > > one). It frees the dsp interface on pause (much like mplayer does). > > I cannot comment on the technical quality of the patch, but I have to > say it's a feature I'd be glad to have in XMMS. xmms already close() and open()s the DSP interface upon un-pausing. I only inserted another close() on the pausing and left the other code paths how they were (it is not a problem to close() an already closed descriptor) as I don't know the whole picture. Cheers, M