Re: [PATCH] Free OSS device on pause
Chris Pitchford <[email protected]> Tue, 10 Oct 2006 20:23:42 +0100 (BST)
| Newsgroups | gmane.comp.multimedia.xmms.devel |
|---|---|
| Message-ID | <[email protected]> |
>> I cannot comment on the technical quality of the patch, but I have to >> say it's a feature I'd be glad to have in XMMS. > > xmms already close() and open()s the DSP interface upon un-pausing. I > only inserted another close() on the pausing and left the other code > paths how they were (it is not a problem to close() an already closed > descriptor) as I don't know the whole picture. Unless the descriptor number was reused elsewhere. That would be bad surely. Are you sure the FD won't be reallocated for use elsewhere between the two close() calls.