Re: build fails for xmms-1.2.10 w/gcc 4.1.0

>  ir.c fails because the static declaration on lines 19 & 22 don't match
>  the header file ir.h.  I removed the static part of the declarations and
>  the build finished fine.
>
>  Details:
>
>  /usr/bin/gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../xmms
>  -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include
>  -D_REENTRANT -I../../intl -I../.. -g -O2 -Wall -Wpointer-arith
>  -finline-functions -ffast-math -funroll-all-loops -MT ir.lo -MD -MP
>  -MF .deps/ir.Tpo -c ir.c  -fPIC -DPIC -o ir.lo
>  ir.c:19: error: static declaration of 'keepGoing' follows non-static
>  declaration
>  ir.h:53: error: previous declaration of 'keepGoing' was here
>  ir.c:22: error: static declaration of 'irapp_thread' follows non-static
>  declaration
>  ir.h:52: error: previous declaration of 'irapp_thread' was here

Confirmed here.

Proposed solution: remove extern declarations of irapp_thread and
keepGoing from ir.h.

diff -ur xmms-1.2.10/General/ir/ir.h xmms-1.2.10-f/General/ir/ir.h
--- xmms-1.2.10/General/ir/ir.h 2001-03-05 14:17:44.000000000 +0100
+++ xmms-1.2.10-f/General/ir/ir.h       2006-10-12 15:20:00.000000000 +0200
@@ -49,8 +49,6 @@
 }
 irConfig;

-extern pthread_t irapp_thread;
-extern gboolean keepGoing;
 extern irConfig ircfg;
 extern gboolean irconf_is_going;

Cheers,
M