RE: [NeoStats-Devel] [Commits] r174 - branches/3.0

Justin Hammond wrote:
> > +/*  TODO:
> > + *  - Akill support.
> > + *  - remove akill must check whether an akill was added by
> > opsb before
> > + *    removing it otherwise blsb becomes a way for opers to 
> > remove any
> > + *    akill on the network including those they may not 
> > normally have
> > + *    access to.
> > + */
> > +
> 
> 
> I'm looking at the existing ban support in NeoStats, and this seems
> troublesome:
> 1) if NeoStats restarts, bans are lost and only resent from 
> the IRCd. How does NeoStats then know what Bot placed the ban?

opsb/neostats ought to maintain a list of bans it has placed as with any
services package. Given that there are potentially 3 separate modules which
could place bans, this is likely better provided in the core. In addition to
providing a remove function for bans placed by NeoStats modules, it could
provide a list mechanism without the need to tell uers to use an IRCd side
command to determine the bans placed.

However, correctly formatted ban messages would allow us to not maintain a
local list yet still determine that neostats or a bot placed a ban. Most
ircds maintain the name of the operator who set a given ban but those that
don't merely need to encode the name of the bot into the ban reason and we
can extract this when required.

> 2) The ban support doesn't even seem to work currently. (at 
> least on Ultimate, I set AKILL's and nothing is injected into 
> the ban hash table)

Known and documented issue:

http://bugs.neostats.net/bug.php?op=show&bugid=210&pos=10

And bans.c:

/*  TODO:
 *  - Other ban types beside Unreal TKL

Still waiting on the promised recv.log collection in order to continue with
it.


Completed ban support would also be likely the best way to determine the
method used by NeoStats in determining ownership of a given ban. Given that
every ircd provides a way to remove bans placed by any operator, a remove
command in NeoStats is just nice to have so there is no need to provide one
at all. As mentioned in the TODO comment, allowing the removal of any ban
from NeoStats is likely to provide opers an ability to remove bans they may
not usually be authorised to remove so IMO, if we cannot restrict it to
removing bans we own, we should not provide the functionality at all.

Mark.