RE: [NeoStats-Devel] [Commits] r2632 - in trunk: . include src

>  	struct sockaddr_in lsa;
> +	struct sockaddr_in srvip;

This causes us to save local information twice since lsa already contains
the ip address of the server. One of the above should be removed.

> +/* MQ Server update sending functions */ typedef enum MQ_MSG_TYPE {
> +	UPDATE_SSREPORT=1,
> +	UPDATE_OPSBREPORT,
> +} MQ_MSG_TYPE;

This creates a unnecessary dependency between the core and modules since any
module wanting to use this requires a core update. Since it is encoded into
a string sent to the update server, why can't this be handled by the module?

Mark.