RE: [NeoStats-Devel] [Commits] r2640 - in trunk/lib: . curl dbm dbm/bdb dbm/gdbm pcre
"M" <[email protected]>
| Newsgroups | gmane.comp.neostats.devel |
|---|---|
| Message-ID | <[email protected]> |
> > > The dbm directory contained dbm modules so lib does not seem an > > > appropriate place to put them. > > > > Well the gdbm sources were in there as well, so I thought you would > > have the same argument if I put them in the modules directory!!! LOL > > > > I actually thought that I'll probably split up the gdbm sources and > > the module files. Would that be better? > > Originally the gdbm source was in the lib directory as a > library but automake could never be persuaded to actually > process the files correctly. > Since I have made a number of modifications to the gdbm > source it is not really library source any more so to solve > both these issues the files were combined into the > src/dbm/gdbm directory. The gdbm sources are unlikely to be > of any use outside the NeoStats source tree due to the changes made. Looking at the new structure, I would suggest either: 1) Move /lib/dbm to /dbm. This matches the choice of /protocol. 2) Move /lib/dbm to /modules/dbm and move /protocol to /modules/protocol/. This matches the fact that protocol and dbm are actually modules so is probably the better option. I think the future of NeoStats is to become more modular where possible since this is the easiest way to avoid bloat and ensure the core code remains clutter free so rather than ending up with lots of top level directories, we are better to create a structure within the module hierarchy. Both of these ensure the lib directory is not populated by NeoStats code or libraries for the sake of libraries or libraries that have been extensively modified for NeoStats so are pointless to consider libraries. IMO, the only things in lib should be libraries that are compiled and used as libraries and are never modified by us in any way but essential for NeoStats to build and run. Mark.