Re: [NeoStats-Devel] [Commits] r2667 - in trunk: . modules/textserv

M wrote:
>>Subject: [NeoStats-Devel] [Commits] r2667 - in trunk: . 
>>Author: DNB
>>+ *    cmdparams->av[3] = optional public access on/off (default off)
>>+ *    cmdparams->av[4] = optional user
>>+ *    cmdparams->av[5] = optional host
> 
> 
> Potential support nightmare here. Since all the above are defined as
> optional, it is reasonable to expect I could skip 3 and 4 but supply 5 and
> it work, however, the way the code works, in order to supply host, I must
> also provide all other options. No matter how well you eventually document
> the command, if you have several optional components in a command, people
> will mess up and ask us before trying to work out why it doesn't work.

not something i thought about, when adding it, i admit. although the 
user and host should really be set in the set options for the bot 
itself, this leaving just the one optional for who can add multiple 
channels.

if the channel was changed back to being optional as well, it could 
check for just the one variable easily enough , either a valid channel, 
or 'ON' or 'OFF' so that the initial channel could be missed entirely 
while still allowing them both to be optional. adding a 3rd option to 
the public access (e.g. "None") could then be the default if nothing was 
given, so that the Bot itself could never be added to any channels. thus 
giving the option for bots like LoveServ to be like the normal Pseudo 
clients. but with the options given and set they could also work similar 
to a botserv type system, giving the best of both worlds in my opinion.

> Since you appear to be changing TextServ to be some sort of BotServ, I
> suggest you rename it accordingly and separate the bot management from the
> database management as you would in a normal BotServ environment thus
> providing the system you want rather than trying to fudge the TextServ
> module commands to manage a BotServ system. 

i was really just adding the multiple channels (which was already in the 
todo) as well as allowing the Nickname to be different to the Database 
Name, (eg. LoveServ instead of loveserv as the file is currently). along 
with creating the sub folder so the files could be seen easily, and not 
mixed in with all the gdbm files.

DNB