RE: [NeoStats-Devel] Core CTCP event handling

I have made changes to the code path which should fix the issue. Please test
the latest revision to ensure it addresses it.

It does make more pertinent a concern I have had since the perl support was
added and that is the multiple code paths generated. I think there is a
stong case to remove the number of #ifdef PERL directives to avoid issues
like this one appearing that are limited to one or the other code path. I
would have looked into this eventually anyway but will make the reduction of
PERL define dependencies a higher priority now.

Mark.
 

> -----Original Message-----
> From: M [mailto:[email protected]] 
> Sent: 30 August 2005 16:50
> To: [email protected]
> Subject: RE: [NeoStats-Devel] Core CTCP event handling
> 
> From a quick look all the potential skipping of the call is missing.
> Therefore, IS_STD_MOD( module_ptr ) relies on some value 
> being set and without Perl, always returns true which is why 
> I have never seen the issue and it has not been reported "in 
> the wild". With perl enabled, this macro fails for the core 
> psuedo module since no attempt has been made to set up the 
> value and the event is skipped. Probably lots of other little 
> bugs will appear as well for the same reason.
> 
> 
> Mark.
> 
> > -----Original Message-----
> > From: Justin Hammond [mailto:justin-kLev/[email protected]]
> > Sent: 30 August 2005 14:05
> > To: [email protected]
> > Subject: RE: [NeoStats-Devel] Core CTCP event handling
> > 
> > Attached is the debug.log file with NeoStats and SecureServ loaded.
> > 
> > 
> > 
> > > -----Original Message-----
> > > From: Justin Hammond [mailto:justin-kLev/[email protected]]
> > > Sent: Monday, August 29, 2005 11:09 PM
> > > To: [email protected]
> > > Subject: RE: [NeoStats-Devel] Core CTCP event handling
> > > 
> > > 
> > > I'll try to run this tomorrow, sorry, been sidetracked by a
> > few other
> > > tasks this last week or so.
> > > 
> > > > -----Original Message-----
> > > > From: M [mailto:[email protected]]
> > > > Sent: Wednesday, August 17, 2005 3:43 AM
> > > > To: [email protected]
> > > > Subject: [NeoStats-Devel] Core CTCP event handling
> > > > 
> > > > 
> > > > I have added a great number of sanity checks and debug
> > information
> > > > to the event subsystem now so it should pretty much
> > document itself
> > > > as it processes an event in debug text. Anyone suffering
> > the problem
> > > > of the core failing to process CTCP events should update to the 
> > > > current SVN
> > > version then run
> > > > neostats with -fd10 and provide me with the debug.log
> > file so I can
> > > > try to work out where the process is failing.
> > > > 
> > > > Mark.
> > > > 
> > > > 
> > > > 
> > > > 
> > > 
> > 
> ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: devel-unsubscribe-wool9L35kifE9wlyV4mCnKxOck334EZe@public.gmane.org
> > > > For additional commands, e-mail: [email protected]
> > > > 
> > > > 
> > > 
> > > 
> > > 
> > 
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: devel-unsubscribe-wool9L35kifE9wlyV4mCnKxOck334EZe@public.gmane.org
> > > For additional commands, e-mail: [email protected]
> > > 
> > > 
> > 
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: devel-unsubscribe-wool9L35kifE9wlyV4mCnKxOck334EZe@public.gmane.org
> For additional commands, e-mail: [email protected]
> 
>