[NeoStats-Devel] [Commits] r2822 - in trunk: modules/connectserv src

Author: Mark
Date: Tue Sep 20 04:49:39 2005
New Revision: 2822

Modified:
   trunk/modules/connectserv/cs.c
   trunk/src/users.c
Log:
make user info field format specifier trusted

Modified: trunk/modules/connectserv/cs.c
==============================================================================
--- trunk/modules/connectserv/cs.c	(original)
+++ trunk/modules/connectserv/cs.c	Tue Sep 20 04:49:39 2005
@@ -289,10 +289,6 @@
 	va_start( ap, fmt );
 	ircvsnprintf( buf, BUFSIZE, fmt, ap );
 	va_end( ap );
-
-	/* make sure the user can't use format specifers to crash/buffer overflow */
-	clean_string(buf, BUFSIZE);
-	
 	irc_chanalert( cs_bot, buf );
 	if( cs_cfg.logging ) 
 		nlog( LOG_NORMAL, buf );

Modified: trunk/src/users.c
==============================================================================
--- trunk/src/users.c	(original)
+++ trunk/src/users.c	Tue Sep 20 04:49:39 2005
@@ -187,6 +187,7 @@
 	strlcpy( u->user->uservhostmask, u->user->userhostmask, USERHOSTLEN );
 	strlcpy( u->user->username, user, MAXUSER );
 	strlcpy( u->info, realname, MAXREALNAME );
+	clean_string( u->info, MAXREALNAME );
 	u->user->ulevel = -1;
 	u->uplink = FindServer( server );
 	u->uplink->server->users++;