Re: info/CWStl77 : SfxPoolItem Create/Store function being removed

Thomas Lange - Oracle <[email protected]> Mon, 18 Oct 2010 15:51:31 +0200
Newsgroups gmane.comp.openoffice.announce.interface
Organization Oracle
Message-ID <[email protected]>
Hi,


> *Summary*
> --------
> In SfxPoolItem and ist derived classes:
> -    virtual SfxPoolItem*     Create(SvStream &, USHORT) const;
> -    virtual SvStream&        Store(SvStream &, USHORT nItemVersion ) const;
> 
> 
> *Description*
> -------------
> As from CWS tl77 the functions
> -    virtual SfxPoolItem*     Create(SvStream &, USHORT) const;
> -    virtual SvStream&        Store(SvStream &, USHORT nItemVersion )
> const;
> will be removed from SfxPoolItem and all its derived classes.
> 
> Wherever those functions are still in need non-virtual function named
> +    SfxPoolItem*     CreateItem(SvStream &, USHORT) const;
> +    SvStream&        StoreItem(SvStream &, USHORT nItemVersion ) const;
> got introduced. (In the long run those should probably be eliminated
> by the responsible engineers as well.)
> 
> Thus when you write new code please don't use them anymore. And if you
> still have need for them please use functions like
> CreateItem/StoreItem as listed above.
> 
> This change is part of getting rid of EditEngines binary clipboard
> format and replacing it with a ODF based clipboard format.
> 


Removing Create/Store from SfxPoolItem and its derived classes also
resulted in some other methods in not from SfxPoolItem derived classes
to get removed as well. Those are:


EditEngineItemPool
editeng/source/editeng/editdoc.hxx
-	virtual SvStream&	Store( SvStream& rStream ) const;


BinTextObject
editeng/source/editeng/editobj2.hxx		
-	virtual void		StoreData( SvStream& rOStream ) const;
-	virtual void		CreateData( SvStream& rIStream );
-	void			CreateData300( SvStream& rIStream );


SfxItemPool
svl/inc/svl/itempool.hxx	
-	const SfxPoolItem*	LoadItem( SvStream &rStream,
-				  FASTBOOL bDirect = FALSE,
-				  const SfxItemPool *pRefPool = 0 );
-	FASTBOOL		StoreItem( SvStream &rStream,
-				   const SfxPoolItem &rItem,
-				   FASTBOOL bDirect = FALSE ) const;
-	virtual SvStream &	Load(SvStream &);
-	virtual SvStream &	Store(SvStream &) const;


SfxItemSet
svl/inc/svl/itemset.hxx	
-	virtual SvStream &	Load( SvStream &, FASTBOOL bDirect ...
-	virtual SvStream &	Store( SvStream &, FASTBOOL bDirect ) const;


SfxStyleSheetBasePool
svl/inc/svl/style.hxx		
-	BOOL 		Load( SvStream& );
-	BOOL 		Store( SvStream&, BOOL bUsed = TRUE );


Thomas