[gsl-issues] [Bug 89286] RTL characters (Hebrew) kerning broken
| Newsgroups | gmane.comp.openoffice.bugs |
|---|---|
| Message-ID | <[email protected]> |
http://openoffice.org/bugzilla/show_bug.cgi?id=89286 iorsh <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76724| |review?([email protected]) Flag| | --- Comment #8 from iorsh <[email protected]> 2011-07-24 19:18:06 --- Created an attachment (id=76724) --> (http://openoffice.org/bugzilla/attachment.cgi?id=76724) Patch against DEV300 This seems to fix the kerning in Comlpex Text Layout. Rationale: Latin text is processed in ServerFontLayoutEngine::operator(), and the kerning is addressed in gcach_layout.cxx:136 by adjusting mnNewWidth. CTL text (e.g. Hebrew) is processed in IcuLayoutEngine::operator(), and mnNewWidth is not adjusted at all (see also TODO comment in gcach_layout.cxx:550). I'm using glyph positions provided by ICU to adjust mnNewWidth. Please kindly review this patch. -- Configure bugmail: http://openoffice.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Bugzilla. Please log into the website and enter your comments. --------------------------------------------------------------------- -- ----------------------------------------------------------------- To unsubscribe send email to [email protected] For additional commands send email to [email protected] with Subject: help -- ----------------------------------------------------------------- To unsubscribe send email to [email protected] For additional commands send email to [email protected] with Subject: help