Re: Mac OS X build of 1.9m91 is available at good-day.

Hi,

NAKATA Maho a écrit :
> Hello,

> this is a list for required patches and cws if available.

1) patch-berkleydb

> patch-scp2+source+ooo+file_library_ooo.scp
> http://www.openoffice.org/issues/show_bug.cgi?id=46802

Ok if you change CONCAT2 with simple string


2)  patch-connectivity

> http://www.openoffice.org/issues/show_bug.cgi?id=46546

Ok for this part, but I have found another problem with Mozilla build, 
and I have to investigate to see if it's my side or not.


3) patch-desktop+inc+db.hxx

> http://www.openoffice.org/issues/show_bug.cgi?id=46548

For this part, I'm not sure. As prototype for Dbt you use :

(one significant line of the patch ) :

+	    Dbt(void *data, u_int32_t size);

I'd prefer  : Dbt(void *data_arg, u_int32_t size);

Found in the sources of bdb-4.2, but 3 possibilities are in this doc... 
So I'm no more sure at all.

Can someone confirm ?


4) patch-jvmfwk+plugins+sunmajor+pluginlib+util.cxx

  patch-jvmfwk+plugins+sunmajor+pluginlib+util.cxx
> http://www.openoffice.org/issues/show_bug.cgi?id=43540

This part is the begining of my recent investigations why db don't work 
at all. It has to be completed with a debug version of OOo (m92 actually 
building with the heavy --enable-debug flag )

And I disagree for integrate this part, because it is :

- experimental
- not yet sure (like Florian told me) it it always usefull.
- to be completed woth other changes I'm actually doing

And if possible, I'd prefer end the work.


5) unomodel.cxx

Ok

> patch-sd+source+ui+unoidl+unomodel.cxx
> (#iZ N/A, same as gcc-3.3 issue...)
> 

6)  HIDCompiler and break in soltools ( missing -lstdc++ )

> patch-soltools+HIDCompiler+makefile.mk
> http://www.openoffice.org/issues/show_bug.cgi?id=37728
> ause019

I disagree here : since ause019, it is no more necessary.


7) For the following, ok (gcc parser )

gcc-3.3  parser

> patch-vcl+source+app+help.cxx
> http://www.openoffice.org/issues/show_bug.cgi?id=46472
> vclfinal01

8) spadmin and testtools crash

> patch-vcl+source+app+svdata.cxx
> http://www.openoffice.org/issues/show_bug.cgi?id=42778
> 

Very important for testtools : good idea

9) gcc-3.3  parser

Ok for the rest

> patch-vcl+source+control+button.cxx
> http://www.openoffice.org/issues/show_bug.cgi?id=45896
> http://www.openoffice.org/issues/show_bug.cgi?id=45930
> vclfinal01

> patch-vcl+unx+source+app+wmadaptor.cxx
> http://www.openoffice.org/issues/show_bug.cgi?id=46539
> vclfinal01


10)  xmlhelp and Dbt prototype (again)

 > patch-xmlhelp+source+cxxhelp+provider+db.hxx
 > http://www.openoffice.org/issues/show_bug.cgi?id=46548
 >

Same thing since  I entered #i37733# : what is the good prototype

My opinion

Regards,
eric bachard


-- 
eric bachard     <[email protected]>
French OpenOffice.org Community developer ( Linux PPC and Mac OS X / X11)
See : <http://fr.openoffice.org>