Re: PowerPC specific issue needs tests on Intel OS

"eric.bachard" <[email protected]>
Newsgroups gmane.comp.openoffice.devel.porting
Message-ID <[email protected]>
Hi Pavel,

Pavel JanĂ­k a ĂŠcrit :
>    From: "eric.bachard" <[email protected]>

> you seem to ask to verify the moz build. Can you please tell us what line
> was changed in the patch? 

Yes, sure, but just the begining ot the patch differs from the original 
(from m105 milestone) :

*** misc/mozilla/build/autoconf/mozconfig-find	Fri Jul 16 20:13:24 2004
--- misc/build/mozilla/build/autoconf/mozconfig-find	Sun Apr 10 00:32:59 
2005
***************
*** 49,54 ****
--- 49,55 ----
   for _config in $MOZCONFIG \
                  $MOZ_MYCONFIG \
                  $topsrcdir/.mozconfig \
+ 	       $topsrcdir/.mozconfig.mk
                  $topsrcdir/mozconfig \
                  $topsrcdir/mozconfig.sh \
                  $topsrcdir/myconfig.sh \


This change is necessary because on Mac OSX, .mozconfig is created (for 
configure) and .mozconfig.mk is expected. So this breask the build.
Just add the good name in the list does it.

On other OS like Linux (for example), just .mozconfig is needed. I think 
my change wont certainly break anything, but I prefer verify.


On IRC, you told me it is only one line, but the
> moz patch is completely changed.

Two patches are attached to #i48810#

the first is the one obtained with, if I'm not wrong, using "official" 
method in moz :

dmake patch
dmake clean
(my changes)
dmake create_patch

-> old is renamed .bak and the new is anormaly big, IMHO. Contextual 
patches are always strange  :-)

The second one is just the one checked from cvs with m105 + unified 
change ( 3 lines before + 3 after the changes)

Because this second solution is more simple/lighter than the previous, 
works for me both on Linux PPC and Mac OSX and saves bandpath, I'd 
prefer use this one.

So I ask...  :-)



Regards,
eric bachard


-- 
<[email protected]>
Francophone OpenOffice.org Commmunity developer (Linux PPC/Mac OS X/X11)
See : <http://fr.openoffice.org>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.