Re: about macxjoin1153 cws

   From: "eric.bachard" <[email protected]>
   Date: Sun, 10 Jul 2005 18:22:53 +0200

Hi,

   > First, I want to explain "why" I have some strange "commits" : because
   > we're several to build on Max OSX, it is important to propose *first*
   > all builders the complete donated code, and choose *after* which part
   > has to be used or deleted.I simply refuse to decide alone in this
   > case.

this is wrong decision. Just send a patch to the list and ask for
review. If patch is OK, then commit it. This way, even good fixes there
will be postponed because of other bad changes :-(

   > > module dlcompat's build.lst contains this change:
   > > Index: prj/build.lst
   > > ===================================================================
   > > RCS file: /cvs/external/dlcompat/prj/build.lst,v
   > > retrieving revision 1.1
   > > retrieving revision 1.1.10.1
   > > diff -u -r1.1 -r1.1.10.1
   > > --- prj/build.lst       22 Mar 2004 15:39:02 -0000      1.1
   > > +++ prj/build.lst       3 Jul 2005 15:01:19 -0000       1.1.10.1
   > > @@ -1,3 +1,3 @@
   > > -dc     dlcompat        :       soltools NULL
   > > +dc     dlcompat        :       soltools dlcompat NULL
   > >  dc     dlcompat                usr1    -       all     dc_mkout NULL
   > >  dc     dlcompat      nmake     -       all     dc_dlcompat NULL
   > > It makes dlcompat depending on itself which is nonsense. What is the
   > > purpose of this fix? Reopening #i51507#.
   > 
   > P. Luby's commit is not complete here. Some other part, probably located 
   > in external, is still missing.

I do not understand this sentence at all, sorry. What other change
elsewhere could make this legitimate change?

   > > +
   > > +# Indic resources are too big for the resource compiler
   > > +RES_HINDI :=
   > > +RES_KANNADA :=
   > > in makefile.mk. This is probably trying to fix #i33228#. See this issues
   > 
   > Yes. I had no issue about this, believing it was Neo or something like 
   > that only.

No. See the issue - OOo and Neo and ... can't build Kannada resources
because of OOo 1.1.x core code limitation.
-- 
Pavel JanĂ­k

Parenthesise to avoid ambiguity.
                  -- The Elements of Programming Style (Kernighan & Plaugher)