Re: [website-dev] Add the "OOo with JRE" checkbox into the green One-Click-Download

Kay Schenk wrote:

Hello Kay,

> I'm actually working on this today, so good to know...

I've done a cvs update and have seen your 2 files in the test section. 
So, I thought about to notify you. ;-)

> and, by the way, I need to track down who "mla" is...is that you?

Yes, (M)arcus (La)nge.

> I notice this page...
> 
> http://download.openoffice.org/other.html#tested-full
> 
> uh...has changed quite a bit and now "Download" is substituted in many
> cases for the version number. Was this on purpose?

"Download" is to indicate the most current version and everything older 
is named by its version number. This is done since a few 3.x releases.

> Also, with the testing I'm doing, if I disable javascript, the checkbox
> goes away (well that's OK).
> 
> But I will also point out the instructions just won't work at all if the
> chekcbox is NOT available/showing.It is virtually impossible to take out
> the "-wJRE" on the fly. At this point, the link has already been
> generated. So, maybe these instructions need to be changed?
> Or...something else.

The checkbox is generated with JavaSript. So, no JS --> no checkbox.

But with JS enabled IMHO it should be possible to exchange the link 
because it's already working on the "other.html" and "all_rc.html" webpages.

> But anyway, thanks for the info...this is indeed an interesting problem
> to say the least.

Yeah, seems to be really tricky. If my knowledge about JS would be 
better I could be of better help. ;-(

Good night.

Marcus



> On 06/16/2010 01:04 PM, Marcus Lange wrote:
>> Hello Kay,
>>
>> I've added some more exceptions for the JRE checkbox as Linux x86-64 RPM
>> and Solaris x86/Sparc is only available with JRE and Linux HPPA, S390X,
>> PPC, IA64 and SDK only without JRE. The "index.html" includes the global
>> "download.js", therefore it applies also to the test section.
>>
>> So, when the browser tells, e.g., OS=Solaris, then always a download
>> link with wJRE builds should be offered, regardless if the checkbox is
>> checked or not. Linux 32/64 Debian always without JRE. And so on.
>>
>> The label text for the checkbox is updated.
>>
>> Best regards
>>
>> Marcus
>>
>>
>>
>> Kay Schenk wrote:
>>> Hi--a quick update on this.
>>>
>>> I am making progress but NOT QUITE THERE yet! :(
>>>
>>> This is one of those cart before the horse issues (things changed later
>>> in the page but how to propagate them up), and well, some solved but ONE
>>> problem still remaining -- a function call to openItem that needs a URL
>>> fix. The inline ones I got to mess with through some JS.
>>>
>>> my  test area is at --
>>> http://download.openoffice.org/test/index_k.html
>>>
>>> more later...
>>>
>>> On 05/20/2010 04:10 PM, Marcus Lange wrote:
>>>> Bernhard Dippold wrote:
>>>>
>>>> Hi Bernhard,
>>>>
>>>>> Could you divide the light green area in two areas? The upper in
>>>>> darker green (like the lower border of the upper area) and only the
>>>>> lower in light green.
>>>> I don't know if I hit the colors but the areas are now divided.
>>>>
>>>>> People intending to download directly will notice hover effect only if
>>>>> they are over the main download area, while clicking on the
>>>>> with/without JRE area will just toggle the checkmark.
>>>>>
>>>>> This would help to understand the different purposes of the two parts
>>>>> actually combined in the light green area.
>>>> Yes, the different events/actions need different areas. But, hm, do you
>>>> really want to have 3 green areas? OK, here you are. :-)
>>>>
>>>>> PS: With a smaller window the new text is wrapped sub-optimal IMHO...
>>>> Fixed with the checkbox code inside a <p> section.
>>>>
>>>>> (and the background images for hover are visible below the normal
>>>>> ones...)
>>>>> If this is not reproducible with your browser and about 800px window
>>>>> width (look at RC and dev-OOo downloads), I'll upload a screenshot
>>>>> (SeaMonkey 2.0.4, Firefox 3.6.3)
>>>> This looks indeed quite ugly. Needs to be fixed (by an CSS expert).
>>>>
>>>> Best regards
>>>>
>>>> Marcus