[otrs-cvs] FAQ/Kernel/System FAQ.pm,1.162,1.163

Comments:
Update of /home/cvs/FAQ/Kernel/System
In directory lancelot:/tmp/cvs-serv2129/Kernel/System

Modified Files:
	FAQ.pm 
Log Message:
Code cleanup.

Author: cr

Index: FAQ.pm
===================================================================
RCS file: /home/cvs/FAQ/Kernel/System/FAQ.pm,v
retrieving revision 1.162
retrieving revision 1.163
diff -2 -u -d -r1.162 -r1.163
--- FAQ.pm	6 Dec 2012 12:50:10 -0000	1.162
+++ FAQ.pm	6 Dec 2012 21:34:28 -0000	1.163
@@ -3704,5 +3704,5 @@
 
         # integer quote the state ids
-        for my $StateTypeID ( keys %{ $Param{States} } ) {
+        for my $StateTypeID ( sort keys %{ $Param{States} } ) {
             $StateTypeID = $Self->{DBObject}->Quote( $StateTypeID, 'Integer' );
         }
@@ -4025,5 +4025,5 @@
     # get the long names of the categories where user has rights
     PARENTID:
-    for my $ParentID ( keys %{$UserCategories} ) {
+    for my $ParentID ( sort keys %{$UserCategories} ) {
 
         next PARENTID if !$UserCategories->{$ParentID};
@@ -4031,5 +4031,5 @@
         next PARENTID if !%{ $UserCategories->{$ParentID} };
 
-        for my $CategoryID ( keys %{ $UserCategories->{$ParentID} } ) {
+        for my $CategoryID ( sort keys %{ $UserCategories->{$ParentID} } ) {
             $UserCategoriesLongNames{$CategoryID} = $CategoryTree->{$CategoryID};
         }
@@ -4160,6 +4160,6 @@
     # extract category ids
     my %AllCategoryIDs;
-    for my $ParentID ( keys %{$CustomerCategories} ) {
-        for my $CategoryID ( keys %{ $CustomerCategories->{$ParentID} } ) {
+    for my $ParentID ( sort keys %{$CustomerCategories} ) {
+        for my $CategoryID ( sort keys %{ $CustomerCategories->{$ParentID} } ) {
             $AllCategoryIDs{$CategoryID} = 1;
         }
@@ -4200,5 +4200,5 @@
     # get the long names of the categories where user has rights
     PARENTID:
-    for my $ParentID ( keys %{$CustomerCategories} ) {
+    for my $ParentID ( sort keys %{$CustomerCategories} ) {
 
         next PARENTID if !$CustomerCategories->{$ParentID};
@@ -4206,5 +4206,5 @@
         next PARENTID if !%{ $CustomerCategories->{$ParentID} };
 
-        for my $CategoryID ( keys %{ $CustomerCategories->{$ParentID} } ) {
+        for my $CategoryID ( sort keys %{ $CustomerCategories->{$ParentID} } ) {
             $CustomerCategoriesLongNames{$CategoryID} = $CategoryTree->{$CategoryID};
         }
@@ -4253,6 +4253,6 @@
     # extract category ids
     my %AllCategoryIDs;
-    for my $ParentID ( keys %{$PublicCategories} ) {
-        for my $CategoryID ( keys %{ $PublicCategories->{$ParentID} } ) {
+    for my $ParentID ( sort keys %{$PublicCategories} ) {
+        for my $CategoryID ( sort keys %{ $PublicCategories->{$ParentID} } ) {
             $AllCategoryIDs{$CategoryID} = 1;
         }
@@ -4292,5 +4292,5 @@
     # get the long names of the categories where user has rights
     PARENTID:
-    for my $ParentID ( keys %{$PublicCategories} ) {
+    for my $ParentID ( sort keys %{$PublicCategories} ) {
 
         next PARENTID if !$PublicCategories->{$ParentID};
@@ -4298,5 +4298,5 @@
         next PARENTID if !%{ $PublicCategories->{$ParentID} };
 
-        for my $CategoryID ( keys %{ $PublicCategories->{$ParentID} } ) {
+        for my $CategoryID ( sort keys %{ $PublicCategories->{$ParentID} } ) {
             $PublicCategoriesLongNames{$CategoryID} = $CategoryTree->{$CategoryID};
         }
@@ -4341,7 +4341,7 @@
 
     for my $Permission (qw(rw ro)) {
-        for my $ParentID ( keys %{$UserCategories} ) {
+        for my $ParentID ( sort keys %{$UserCategories} ) {
             my $Categories = $UserCategories->{$ParentID};
-            for my $CategoryID ( keys %{$Categories} ) {
+            for my $CategoryID ( sort keys %{$Categories} ) {
                 if ( $CategoryID == $Param{CategoryID} ) {
                     return $Permission;
@@ -4390,7 +4390,7 @@
             UserID       => $Param{UserID},
         );
-        for my $ParentID ( keys %{$CustomerCategories} ) {
+        for my $ParentID ( sort keys %{$CustomerCategories} ) {
             my $Categories = $CustomerCategories->{$ParentID};
-            for my $CategoryID ( keys %{$Categories} ) {
+            for my $CategoryID ( sort keys %{$Categories} ) {
                 if ( $CategoryID == $Param{CategoryID} ) {
                     return $Permission;
@@ -4995,5 +4995,5 @@
 
         CATEGORYID:
-        for my $CategoryID ( keys %{ $Param{Categories}->{$ParentID} } ) {
+        for my $CategoryID ( sort keys %{ $Param{Categories}->{$ParentID} } ) {
 
             # check category groups
@@ -5002,5 +5002,5 @@
             # check user groups
             GROUPID:
-            for my $GroupID ( keys %{ $Param{CategoryGroups}->{$CategoryID} } ) {
+            for my $GroupID ( sort keys %{ $Param{CategoryGroups}->{$CategoryID} } ) {
 
                 next GROUPID if !defined $Param{UserGroups}->{$GroupID};
---------------------------------------------------------------------
OTRS mailing list: cvs-log - Webpage: http://otrs.org/
Archive: http://lists.otrs.org/pipermail/cvs-log
To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/cvs-log