[otrs-cvs] otrs/Kernel/Modules AgentTicketActionCommon.pm, 1.104, 1.105 AgentTicketPhone.pm, 1.250, 1.251 AgentTicketEmail.pm, 1.219, 1.220

Comments:
Update of /home/cvs/otrs/Kernel/Modules
In directory lancelot:/tmp/cvs-serv510/Kernel/Modules

Modified Files:
	AgentTicketActionCommon.pm AgentTicketPhone.pm 
	AgentTicketEmail.pm 
Log Message:
 - 2013-01-29 Fixed bug#9096 - All services list is shown instead of only default services.

Author: cr

Index: AgentTicketActionCommon.pm
===================================================================
RCS file: /home/cvs/otrs/Kernel/Modules/AgentTicketActionCommon.pm,v
retrieving revision 1.104
retrieving revision 1.105
diff -2 -u -d -r1.104 -r1.105
--- AgentTicketActionCommon.pm	28 Jan 2013 10:06:42 -0000	1.104
+++ AgentTicketActionCommon.pm	30 Jan 2013 00:00:42 -0000	1.105
@@ -1789,10 +1789,13 @@
         = $Self->{ConfigObject}->Get('Ticket::Service::Default::UnknownCustomer');
 
+    # check if no CustomerUserID is selected
+    # if $DefaultServiceUnknownCustomer = 0 leave CustomerUserID empty, it will not get any services
+    # if $DefaultServiceUnknownCustomer = 1 set CustomerUserID to get default services
+    if ( !$Param{CustomerUserID} && $DefaultServiceUnknownCustomer ) {
+        $Param{CustomerUserID} = '<DEFAULT>';
+    }
+
     # get service list
-    if (
-        ( defined $Param{CustomerUserID} && $Param{CustomerUserID} )
-        || $DefaultServiceUnknownCustomer
-        )
-    {
+    if ( $Param{CustomerUserID} ) {
         %Service = $Self->{TicketObject}->TicketServiceList(
             %Param,

Author: cr

Index: AgentTicketPhone.pm
===================================================================
RCS file: /home/cvs/otrs/Kernel/Modules/AgentTicketPhone.pm,v
retrieving revision 1.250
retrieving revision 1.251
diff -2 -u -d -r1.250 -r1.251
--- AgentTicketPhone.pm	11 Dec 2012 22:29:58 -0000	1.250
+++ AgentTicketPhone.pm	30 Jan 2013 00:00:42 -0000	1.251
@@ -1,5 +1,5 @@
 # --
 # Kernel/Modules/AgentTicketPhone.pm - to handle phone calls
-# Copyright (C) 2001-2012 OTRS AG, http://otrs.org/
+# Copyright (C) 2001-2013 OTRS AG, http://otrs.org/
 # --
 # $Id$
@@ -1666,6 +1666,13 @@
         = $Self->{ConfigObject}->Get('Ticket::Service::Default::UnknownCustomer');
 
+    # check if no CustomerUserID is selected
+    # if $DefaultServiceUnknownCustomer = 0 leave CustomerUserID empty, it will not get any services
+    # if $DefaultServiceUnknownCustomer = 1 set CustomerUserID to get default services
+    if ( !$Param{CustomerUserID} && $DefaultServiceUnknownCustomer ) {
+        $Param{CustomerUserID} = '<DEFAULT>';
+    }
+
     # get service list
-    if ( $Param{CustomerUserID} || $DefaultServiceUnknownCustomer ) {
+    if ( $Param{CustomerUserID} ) {
         %Service = $Self->{TicketObject}->TicketServiceList(
             %Param,

Author: cr

Index: AgentTicketEmail.pm
===================================================================
RCS file: /home/cvs/otrs/Kernel/Modules/AgentTicketEmail.pm,v
retrieving revision 1.219
retrieving revision 1.220
diff -2 -u -d -r1.219 -r1.220
--- AgentTicketEmail.pm	20 Nov 2012 14:48:37 -0000	1.219
+++ AgentTicketEmail.pm	30 Jan 2013 00:00:42 -0000	1.220
@@ -1,5 +1,5 @@
 # --
 # Kernel/Modules/AgentTicketEmail.pm - to compose initial email to customer
-# Copyright (C) 2001-2012 OTRS AG, http://otrs.org/
+# Copyright (C) 2001-2013 OTRS AG, http://otrs.org/
 # --
 # $Id$
@@ -1728,6 +1728,13 @@
         = $Self->{ConfigObject}->Get('Ticket::Service::Default::UnknownCustomer');
 
+    # check if no CustomerUserID is selected
+    # if $DefaultServiceUnknownCustomer = 0 leave CustomerUserID empty, it will not get any services
+    # if $DefaultServiceUnknownCustomer = 1 set CustomerUserID to get default services
+    if ( !$Param{CustomerUserID} && $DefaultServiceUnknownCustomer ) {
+        $Param{CustomerUserID} = '<DEFAULT>';
+    }
+
     # get service list
-    if ( $Param{CustomerUserID} || $DefaultServiceUnknownCustomer ) {
+    if ( $Param{CustomerUserID} ) {
         %Service = $Self->{TicketObject}->TicketServiceList(
             %Param,
---------------------------------------------------------------------
OTRS mailing list: cvs-log - Webpage: http://otrs.org/
Archive: http://lists.otrs.org/pipermail/cvs-log
To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/cvs-log