[otrs-cvs] ITSMConfigurationManagement/Kernel/System/ITSMConfigItem Version.pm, 1.36, 1.37 Number.pm, 1.5, 1.6

Comments:
Update of /home/cvs/ITSMConfigurationManagement/Kernel/System/ITSMConfigItem
In directory lancelot:/tmp/cvs-serv23588/Kernel/System/ITSMConfigItem

Modified Files:
	Version.pm Number.pm 
Log Message:
Fixed bug# 9547 - XSS and SQL injection vulnerability in module AgentITSMConfigItemSearch on parameter ClassID.

Author: ub

Index: Version.pm
===================================================================
RCS file: /home/cvs/ITSMConfigurationManagement/Kernel/System/ITSMConfigItem/Version.pm,v
retrieving revision 1.36
retrieving revision 1.37
diff -2 -u -d -r1.36 -r1.37
--- Version.pm	7 Jun 2013 11:52:42 -0000	1.36
+++ Version.pm	28 Jun 2013 11:22:32 -0000	1.37
@@ -956,7 +956,7 @@
         next ARRAYPARAM if !@{ $Param{$ArrayParam} };
 
-        # quote
+        # quote as integer
         for my $OneParam ( @{ $Param{$ArrayParam} } ) {
-            $OneParam = $Self->{DBObject}->Quote($OneParam);
+            $OneParam = $Self->{DBObject}->Quote( $OneParam, 'Integer' );
         }
 
@@ -975,5 +975,5 @@
     my $WhereString = @SQLWhere ? ' WHERE ' . join q{ AND }, @SQLWhere : '';
 
-    # set limit
+    # set limit, quote as integer
     if ( $Param{Limit} ) {
         $Param{Limit} = $Self->{DBObject}->Quote( $Param{Limit}, 'Integer' );

Author: ub

Index: Number.pm
===================================================================
RCS file: /home/cvs/ITSMConfigurationManagement/Kernel/System/ITSMConfigItem/Number.pm,v
retrieving revision 1.5
retrieving revision 1.6
diff -2 -u -d -r1.5 -r1.6
--- Number.pm	20 Nov 2012 19:05:54 -0000	1.5
+++ Number.pm	28 Jun 2013 11:22:32 -0000	1.6
@@ -1,5 +1,5 @@
 # --
 # Kernel/System/ITSMConfigItem/Number.pm - sub module of ITSMConfigItem.pm with number functions
-# Copyright (C) 2001-2012 OTRS AG, http://otrs.org/
+# Copyright (C) 2001-2013 OTRS AG, http://otrs.org/
 # --
 # $Id$
@@ -90,7 +90,4 @@
         if $Self->{Cache}->{ConfigItemNumberLookup}->{Number}->{ $Param{ConfigItemNumber} };
 
-    # quote
-    $Param{ConfigItemNumber} = $Self->{DBObject}->Quote( $Param{ConfigItemNumber} );
-
     # ask database
     $Self->{DBObject}->Prepare(
---------------------------------------------------------------------
OTRS mailing list: cvs-log - Webpage: http://otrs.org/
Archive: http://lists.otrs.org/pipermail/cvs-log
To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/cvs-log