[otrs-cvs] ITSMChangeManagement/Kernel/System/ITSMChange Template.pm, 1.58, 1.58.2.1 ITSMWorkOrder.pm, 1.123.2.4, 1.123.2.5

Comments:
Update of /home/cvs/ITSMChangeManagement/Kernel/System/ITSMChange
In directory lancelot:/tmp/cvs-serv17045/Kernel/System/ITSMChange

Modified Files:
      Tag: rel-3_0
	Template.pm ITSMWorkOrder.pm 
Log Message:
Improved quoting for integer values to avoid possible security issues.

Author: ub

Index: Template.pm
===================================================================
RCS file: /home/cvs/ITSMChangeManagement/Kernel/System/ITSMChange/Template.pm,v
retrieving revision 1.58
retrieving revision 1.58.2.1
diff -2 -u -d -r1.58 -r1.58.2.1
--- Template.pm	14 Feb 2011 13:52:58 -0000	1.58
+++ Template.pm	28 Jun 2013 13:03:00 -0000	1.58.2.1
@@ -1,5 +1,5 @@
 # --
 # Kernel/System/ITSMChange/Template.pm - all template functions
-# Copyright (C) 2001-2011 OTRS AG, http://otrs.org/
+# Copyright (C) 2001-2013 OTRS AG, http://otrs.org/
 # --
 # $Id$
@@ -808,7 +808,7 @@
         next ARRAYPARAM if !@{ $Param{$ArrayParam} };
 
-        # quote
+        # quote as integer
         for my $OneParam ( @{ $Param{$ArrayParam} } ) {
-            $OneParam = $Self->{DBObject}->Quote($OneParam);
+            $OneParam = $Self->{DBObject}->Quote( $OneParam, 'Integer' );
         }
 

Author: ub

Index: ITSMWorkOrder.pm
===================================================================
RCS file: /home/cvs/ITSMChangeManagement/Kernel/System/ITSMChange/ITSMWorkOrder.pm,v
retrieving revision 1.123.2.4
retrieving revision 1.123.2.5
diff -2 -u -d -r1.123.2.4 -r1.123.2.5
--- ITSMWorkOrder.pm	23 Oct 2012 13:16:57 -0000	1.123.2.4
+++ ITSMWorkOrder.pm	28 Jun 2013 13:03:00 -0000	1.123.2.5
@@ -1,5 +1,5 @@
 # --
 # Kernel/System/ITSMChange/ITSMWorkOrder.pm - all workorder functions
-# Copyright (C) 2001-2012 OTRS AG, http://otrs.org/
+# Copyright (C) 2001-2013 OTRS AG, http://otrs.org/
 # --
 # $Id$
@@ -1339,7 +1339,7 @@
         next ARRAYPARAM if !@{ $Param{$ArrayParam} };
 
-        # quote
+        # quote as integer
         for my $OneParam ( @{ $Param{$ArrayParam} } ) {
-            $OneParam = $Self->{DBObject}->Quote($OneParam);
+            $OneParam = $Self->{DBObject}->Quote( $OneParam, 'Integer' );
         }
 
@@ -1801,5 +1801,5 @@
             Class => 'ITSM::ChangeManagement::WorkOrder::State',
             )
-        };
+    };
 
     # check the state hash
@@ -1983,5 +1983,5 @@
             Class => 'ITSM::ChangeManagement::WorkOrder::Type',
             )
-        };
+    };
 
     # check the workorder types hash
---------------------------------------------------------------------
OTRS mailing list: cvs-log - Webpage: http://otrs.org/
Archive: http://lists.otrs.org/pipermail/cvs-log
To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/cvs-log