[otrs-cvs] ITSMChangeManagement/scripts/test ITSMChange.t, 1.195, 1.195.4.1

"CVS commits notifications of OTRS.org" <[email protected]> Fri, 28 Jun 2013 13:03:57 +0000
Newsgroups gmane.comp.otrs.cvs
Message-ID <[email protected]>
Comments:
Update of /home/cvs/ITSMChangeManagement/scripts/test
In directory lancelot:/tmp/cvs-serv17288/scripts/test

Modified Files:
      Tag: rel-3_2
	ITSMChange.t 
Log Message:
Improved quoting for integer values to avoid possible security issues.

Author: ub

Index: ITSMChange.t
===================================================================
RCS file: /home/cvs/ITSMChangeManagement/scripts/test/ITSMChange.t,v
retrieving revision 1.195
retrieving revision 1.195.4.1
diff -2 -u -d -r1.195 -r1.195.4.1
--- ITSMChange.t	14 Nov 2012 14:07:29 -0000	1.195
+++ ITSMChange.t	28 Jun 2013 13:03:52 -0000	1.195.4.1
@@ -1,5 +1,5 @@
 # --
 # ITSMChange.t - change tests
-# Copyright (C) 2001-2012 OTRS AG, http://otrs.org/
+# Copyright (C) 2001-2013 OTRS AG, http://otrs.org/
 # --
 # $Id$
@@ -41,17 +41,17 @@
 $Self->{ValidObject}          = Kernel::System::Valid->new( %{$Self} );
 $Self->{GeneralCatalogObject} = Kernel::System::GeneralCatalog->new( %{$Self} );
-$Self->{ChangeObject}         = Kernel::System::ITSMChange->new( %{$Self} );
-$Self->{CIPAllocateObject}    = Kernel::System::ITSMChange::ITSMChangeCIPAllocate->new( %{$Self} );
-$Self->{WorkOrderObject}      = Kernel::System::ITSMChange::ITSMWorkOrder->new( %{$Self} );
-$Self->{HistoryObject}        = Kernel::System::ITSMChange::History->new( %{$Self} );
-$Self->{CacheObject}          = Kernel::System::Cache->new( %{$Self} );
+my $WorkOrderObject = Kernel::System::ITSMChange::ITSMWorkOrder->new( %{$Self} );
+my $ChangeObject    = Kernel::System::ITSMChange->new( %{$Self} );
+$Self->{CIPAllocateObject} = Kernel::System::ITSMChange::ITSMChangeCIPAllocate->new( %{$Self} );
+$Self->{HistoryObject}     = Kernel::System::ITSMChange::History->new( %{$Self} );
+$Self->{CacheObject}       = Kernel::System::Cache->new( %{$Self} );
 
 # test if change object was created successfully
 $Self->True(
-    $Self->{ChangeObject},
+    $ChangeObject,
     "Test " . $TestCount++ . ' - construction of change object',
 );
 $Self->Is(
-    ref $Self->{ChangeObject},
+    ref $ChangeObject,
     'Kernel::System::ITSMChange',
     "Test " . $TestCount++ . ' - class of change object',
@@ -185,5 +185,5 @@
 for my $ObjectMethod (@ObjectMethods) {
     $Self->True(
-        $Self->{ChangeObject}->can($ObjectMethod),
+        $ChangeObject->can($ObjectMethod),
         "Test " . $TestCount++ . " - check 'can $ObjectMethod'",
     );
@@ -234,5 +234,5 @@
 
     # look up the state name
-    my $LookedUpStateID = $Self->{ChangeObject}->ChangeStateLookup(
+    my $LookedUpStateID = $ChangeObject->ChangeStateLookup(
         ChangeState => $State,
     );
@@ -245,5 +245,5 @@
 
     # do the reverse lookup
-    my $LookedUpState = $Self->{ChangeObject}->ChangeStateLookup(
+    my $LookedUpState = $ChangeObject->ChangeStateLookup(
         ChangeStateID => $LookedUpStateID,
     );
@@ -257,5 +257,5 @@
 
 # now some param checks for ChangeStateLookup
-my $LookupOk = $Self->{ChangeObject}->ChangeStateLookup();
+my $LookupOk = $ChangeObject->ChangeStateLookup();
 
 $Self->False(
@@ -264,5 +264,5 @@
 );
 
-$LookupOk = $Self->{ChangeObject}->ChangeStateLookup(
+$LookupOk = $ChangeObject->ChangeStateLookup(
     ChangeState   => 'approved',
     ChangeStateID => 2,
@@ -274,5 +274,5 @@
 );
 
-$LookupOk = $Self->{ChangeObject}->ChangeStateLookup(
+$LookupOk = $ChangeObject->ChangeStateLookup(
     State => 'approved',
 );
@@ -283,5 +283,5 @@
 );
 
-$LookupOk = $Self->{ChangeObject}->ChangeStateLookup(
+$LookupOk = $ChangeObject->ChangeStateLookup(
     StateID => 2,
 );
@@ -406,5 +406,5 @@
     );
 
-    my $CategoryID = $Self->{ChangeObject}->ChangeCIPLookup(
+    my $CategoryID = $ChangeObject->ChangeCIPLookup(
         Type => 'Category',
         CIP  => $CIPValue,
@@ -421,5 +421,5 @@
     );
 
-    my $ImpactID = $Self->{ChangeObject}->ChangeCIPLookup(
+    my $ImpactID = $ChangeObject->ChangeCIPLookup(
         Type => 'Impact',
         CIP  => $CIPValue,
@@ -436,5 +436,5 @@
     );
 
-    my $PriorityID = $Self->{ChangeObject}->ChangeCIPLookup(
+    my $PriorityID = $ChangeObject->ChangeCIPLookup(
         Type => 'Priority',
         CIP  => $CIPValue,
@@ -2499,5 +2499,5 @@
 
         # add the change
-        $ChangeID = $Self->{ChangeObject}->ChangeAdd(
+        $ChangeID = $ChangeObject->ChangeAdd(
             %{ $SourceData->{ChangeAdd} }
         );
@@ -2559,5 +2559,5 @@
 
         # update the change
-        my $ChangeUpdateSuccess = $Self->{ChangeObject}->ChangeUpdate(
+        my $ChangeUpdateSuccess = $ChangeObject->ChangeUpdate(
             ChangeID => $ChangeID,
             %{ $SourceData->{ChangeUpdate} },
@@ -2591,5 +2591,5 @@
 
     if ( $SourceData->{ChangeCABUpdate} && $ChangeID ) {
-        my $CABUpdateSuccess = $Self->{ChangeObject}->ChangeCABUpdate(
+        my $CABUpdateSuccess = $ChangeObject->ChangeCABUpdate(
             %{ $SourceData->{ChangeCABUpdate} },
             ChangeID => $ChangeID,
@@ -2622,5 +2622,5 @@
             # test void context
             $Self->False(
-                $Self->{ChangeObject}->ChangeCABDelete() || 0,
+                $ChangeObject->ChangeCABDelete() || 0,
                 "Test $TestCount: |- ChangeCABDelete",
             );
@@ -2632,5 +2632,5 @@
             for my $FailTest (@DeleteTests) {
                 $Self->False(
-                    $Self->{ChangeObject}->ChangeCABDelete( %{$FailTest} ) || 0,
+                    $ChangeObject->ChangeCABDelete( %{$FailTest} ) || 0,
                     "Test $TestCount: |- ChangeCABDelete",
                 );
@@ -2641,5 +2641,5 @@
             # Delete with all params
             $Self->True(
-                $Self->{ChangeObject}->ChangeCABDelete(%CABDeleteParams),
+                $ChangeObject->ChangeCABDelete(%CABDeleteParams),
                 "Test $TestCount: |- ChangeCABDelete",
             );
@@ -2649,5 +2649,5 @@
     # add a workorder
     if ( $SourceData->{WorkOrderAdd} ) {
-        my $WorkOrderID = $Self->{WorkOrderObject}->WorkOrderAdd(
+        my $WorkOrderID = $WorkOrderObject->WorkOrderAdd(
             %{ $SourceData->{WorkOrderAdd} },
             ChangeID => $ChangeID,
@@ -2665,5 +2665,5 @@
         my $ChangeGetReferenceData = $ReferenceData->{ChangeGet};
 
-        my $ChangeData = $Self->{ChangeObject}->ChangeGet(
+        my $ChangeData = $ChangeObject->ChangeGet(
             ChangeID => $ChangeID,
             UserID   => 1,
@@ -2718,5 +2718,5 @@
 
     if ( $ReferenceData->{ChangeCABGet} ) {
-        my $CABData = $Self->{ChangeObject}->ChangeCABGet(
+        my $CABData = $ChangeObject->ChangeCABGet(
             %{ $ReferenceData->{ChangeCABGet} },
             UserID   => 1,
@@ -2807,5 +2807,5 @@
 
     # add a new change with CABCustomer $CustomerUserIDs[2]
-    my $ChangeID = $Self->{ChangeObject}->ChangeAdd(
+    my $ChangeID = $ChangeObject->ChangeAdd(
         ChangeTitle     => 'ABC',
         Description     => 'DEF',
@@ -2828,5 +2828,5 @@
 
     # search for the change ids
-    my $ChangeIDs = $Self->{ChangeObject}->ChangeSearch(
+    my $ChangeIDs = $ChangeObject->ChangeSearch(
         CABCustomers     => [ $CustomerUserIDs[2] ],
         OrderByDirection => ['Up'],
@@ -2861,5 +2861,5 @@
 
     # delete the Change
-    my $DeleteSuccess = $Self->{ChangeObject}->ChangeDelete(
+    my $DeleteSuccess = $ChangeObject->ChangeDelete(
         ChangeID => $ChangeID,
         UserID   => 1,
@@ -2884,10 +2884,10 @@
 
 if ($ChangeLookupTestChangeID) {
-    my $ChangeData = $Self->{ChangeObject}->ChangeGet(
+    my $ChangeData = $ChangeObject->ChangeGet(
         ChangeID => $ChangeLookupTestChangeID,
         UserID   => 1,
     );
 
-    my $ChangeID = $Self->{ChangeObject}->ChangeLookup(
+    my $ChangeID = $ChangeObject->ChangeLookup(
         ChangeNumber => $ChangeData->{ChangeNumber},
     );
@@ -2900,5 +2900,5 @@
     );
 
-    my $ChangeNumber = $Self->{ChangeObject}->ChangeLookup(
+    my $ChangeNumber = $ChangeObject->ChangeLookup(
         ChangeID => $ChangeLookupTestChangeID,
     );
@@ -2913,5 +2913,5 @@
 
     # now some param checks for ChangeLookup()
-    my $LookupOk = $Self->{ChangeObject}->ChangeLookup( UserID => 1 );
+    my $LookupOk = $ChangeObject->ChangeLookup( UserID => 1 );
 
     $Self->False(
@@ -2920,5 +2920,5 @@
     );
 
-    $LookupOk = $Self->{ChangeObject}->ChangeLookup();
+    $LookupOk = $ChangeObject->ChangeLookup();
 
     $Self->False(
@@ -2927,5 +2927,5 @@
     );
 
-    $LookupOk = $Self->{ChangeObject}->ChangeLookup(
+    $LookupOk = $ChangeObject->ChangeLookup(
         ChangeID     => $ChangeLookupTestChangeID,
         ChangeNumber => $ChangeData->{ChangeNumber},
@@ -2942,5 +2942,5 @@
 # we cannot test for a specific number as these tests can be run in existing environments
 # where other changes already exist
-my $ChangeList = $Self->{ChangeObject}->ChangeList( UserID => 1 ) || [];
+my $ChangeList = $ChangeObject->ChangeList( UserID => 1 ) || [];
 my %ChangeListMap = map { $_ => 1 } @{$ChangeList};
 
@@ -3889,5 +3889,5 @@
 
 if ($SearchTestChangeID) {
-    my $SearchTestChange = $Self->{ChangeObject}->ChangeGet(
+    my $SearchTestChange = $ChangeObject->ChangeGet(
         ChangeID => $SearchTestChangeID,
         UserID   => 1,
@@ -4118,5 +4118,5 @@
 
     # get a ref to an array of found ids
-    my $ChangeIDs = $Self->{ChangeObject}->ChangeSearch(
+    my $ChangeIDs = $ChangeObject->ChangeSearch(
         %{ $Test->{SearchData} },
         Result => 'ARRAY',
@@ -4125,5 +4125,5 @@
 
     # get a count of found ids
-    my $CountChangeIDs = $Self->{ChangeObject}->ChangeSearch(
+    my $CountChangeIDs = $ChangeObject->ChangeSearch(
         %{ $Test->{SearchData} },
         Result => 'COUNT',
@@ -4210,5 +4210,5 @@
 
 for my $ChangeIDForOrderByTests (@OrderBySearchTestChangeIDs) {
-    my $ChangeData = $Self->{ChangeObject}->ChangeGet(
+    my $ChangeData = $ChangeObject->ChangeGet(
         ChangeID => $ChangeIDForOrderByTests,
         UserID   => 1,
@@ -4264,5 +4264,5 @@
     my $ReferenceList = Data::Dumper::Dumper( \@SortedIDs );
 
-    my $SearchResult = $Self->{ChangeObject}->ChangeSearch(
+    my $SearchResult = $ChangeObject->ChangeSearch(
         ChangeTitle      => 'OrderByChange - Title - ' . $UniqueSignature,
         OrderBy          => [$OrderByColumn],
@@ -4300,5 +4300,5 @@
     my $ReferenceListDown = Data::Dumper::Dumper( \@SortedIDsDown );
 
-    my $SearchResultDown = $Self->{ChangeObject}->ChangeSearch(
+    my $SearchResultDown = $ChangeObject->ChangeSearch(
         ChangeTitle => 'OrderByChange - Title - ' . $UniqueSignature,
         OrderBy     => [$OrderByColumn],
@@ -4316,5 +4316,5 @@
 
     # check if ITSMChange.pm handles non-existent OrderByDirection criteria correct
-    my $SearchResultSideways = $Self->{ChangeObject}->ChangeSearch(
+    my $SearchResultSideways = $ChangeObject->ChangeSearch(
         ChangeTitle      => 'OrderByChange - Title - ' . $UniqueSignature,
         OrderBy          => [$OrderByColumn],
@@ -4334,5 +4334,5 @@
 
     # check for 'OrderBy' with non-existent column
-    my $SearchResultFooBarColumn = $Self->{ChangeObject}->ChangeSearch(
+    my $SearchResultFooBarColumn = $ChangeObject->ChangeSearch(
         ChangeTitle => 'OrderByChange - Title - ' . $UniqueSignature,
         OrderBy     => ['FooBar'],
@@ -4347,5 +4347,5 @@
 
     # check for 'OrderBy' with non-existent column
-    my $SearchResultFooBarColumnDirection = $Self->{ChangeObject}->ChangeSearch(
+    my $SearchResultFooBarColumnDirection = $ChangeObject->ChangeSearch(
         ChangeTitle      => 'OrderByChange - Title - ' . $UniqueSignature,
         OrderBy          => ['FooBar'],
@@ -4361,5 +4361,5 @@
 
     # check for 'OrderBy' with non-existent column
-    my $SearchResultFooBarDoubleColumn = $Self->{ChangeObject}->ChangeSearch(
+    my $SearchResultFooBarDoubleColumn = $ChangeObject->ChangeSearch(
         ChangeTitle => 'OrderByChange - Title - ' . $UniqueSignature,
         OrderBy     => [ 'ChangeID', 'ChangeID' ],
@@ -4384,5 +4384,5 @@
 my @ChangesForSecondOrderByTests;
 for my $ChangeIDForSecondOrderByTests (@OrderBySearchTestChangeIDs) {
-    my $ChangeData = $Self->{ChangeObject}->ChangeGet(
+    my $ChangeData = $ChangeObject->ChangeGet(
         ChangeID => $ChangeIDForSecondOrderByTests,
         UserID   => 1,
@@ -4409,5 +4409,5 @@
     local $Data::Dumper::Useqq  = 1;
 
-    my $SearchResult = $Self->{ChangeObject}->ChangeSearch(
+    my $SearchResult = $ChangeObject->ChangeSearch(
         ChangeTitle      => 'OrderByChange - Title - ' . $UniqueSignature,
         OrderBy          => [ 'CreateTime', 'ChangeID' ],
@@ -4862,5 +4862,5 @@
 
     if ( $SourceData->{ChangeAdd} ) {
-        $ChangeID = $Self->{ChangeObject}->ChangeAdd(
+        $ChangeID = $ChangeObject->ChangeAdd(
             %{ $SourceData->{ChangeAdd} },
         );
@@ -4878,5 +4878,5 @@
 
     if ( $SourceData->{WorkOrderAdd} ) {
-        $WorkOrderID = $Self->{WorkOrderObject}->WorkOrderAdd(
+        $WorkOrderID = $WorkOrderObject->WorkOrderAdd(
             %{ $SourceData->{WorkOrderAdd} },
             ChangeID => $ChangeID,
@@ -4893,5 +4893,5 @@
     my $SearchResult;
     if ( $SourceData->{ChangeSearch} ) {
-        $SearchResult = $Self->{ChangeObject}->ChangeSearch(
+        $SearchResult = $ChangeObject->ChangeSearch(
             %{ $SourceData->{ChangeSearch} },
         );
@@ -4950,5 +4950,5 @@
 
 for my $ChangeIDForOrderByCIPTests (@OrderByCIPChangeIDs) {
-    my $ChangeData = $Self->{ChangeObject}->ChangeGet(
+    my $ChangeData = $ChangeObject->ChangeGet(
         ChangeID => $ChangeIDForOrderByCIPTests,
         UserID   => 1,
@@ -4981,5 +4981,5 @@
     my $ReferenceList = Data::Dumper::Dumper( \@SortedIDs );
 
-    my $SearchResult = $Self->{ChangeObject}->ChangeSearch(
+    my $SearchResult = $ChangeObject->ChangeSearch(
         ChangeTitle      => '%CIP%' . $UniqueSignature,
         OrderBy          => [$CIPColumn],
@@ -5008,5 +5008,5 @@
     my $ReferenceListDown = Data::Dumper::Dumper( \@SortedIDsDown );
 
-    my $SearchResultDown = $Self->{ChangeObject}->ChangeSearch(
+    my $SearchResultDown = $ChangeObject->ChangeSearch(
         ChangeTitle => '%CIP%' . $UniqueSignature,
         OrderBy     => [$CIPColumn],
@@ -5024,5 +5024,5 @@
 
     # check if ITSMChange.pm handles non-existent OrderByDirection criteria correct
-    my $SearchResultSideways = $Self->{ChangeObject}->ChangeSearch(
+    my $SearchResultSideways = $ChangeObject->ChangeSearch(
         ChangeTitle      => '%CIP%' . $UniqueSignature,
         OrderBy          => [$CIPColumn],
@@ -5177,5 +5177,5 @@
 
     if ( $SourceData->{ChangeAdd} ) {
-        $ChangeID = $Self->{ChangeObject}->ChangeAdd(
+        $ChangeID = $ChangeObject->ChangeAdd(
             %{ $SourceData->{ChangeAdd} },
         );
@@ -5193,5 +5193,5 @@
 
     if ( $SourceData->{WorkOrderAdd} ) {
-        $WorkOrderID = $Self->{WorkOrderObject}->WorkOrderAdd(
+        $WorkOrderID = $WorkOrderObject->WorkOrderAdd(
             %{ $SourceData->{WorkOrderAdd} },
             ChangeID => $ChangeID,
@@ -5208,5 +5208,5 @@
     my $SearchResult;
     if ( $SourceData->{ChangeSearch} ) {
-        $SearchResult = $Self->{ChangeObject}->ChangeSearch(
+        $SearchResult = $ChangeObject->ChangeSearch(
             %{ $SourceData->{ChangeSearch} },
         );
@@ -5258,5 +5258,5 @@
 # each of the changes should have one workorder
 for my $ChangeID (@WOSTChangeIDs) {
-    my $ChangeData = $Self->{ChangeObject}->ChangeGet(
+    my $ChangeData = $ChangeObject->ChangeGet(
         ChangeID => $ChangeID,
         UserID   => 1,
@@ -5362,5 +5362,5 @@
 
     if ( $SourceData->{ChangeAdd} ) {
-        $ChangeID = $Self->{ChangeObject}->ChangeAdd(
+        $ChangeID = $ChangeObject->ChangeAdd(
             %{ $SourceData->{ChangeAdd} },
         );
@@ -5379,5 +5379,5 @@
 
     if ( $SourceData->{WorkOrderAdd} ) {
-        $WorkOrderID = $Self->{WorkOrderObject}->WorkOrderAdd(
+        $WorkOrderID = $WorkOrderObject->WorkOrderAdd(
             %{ $SourceData->{WorkOrderAdd} },
             ChangeID => $ChangeID,
@@ -5394,5 +5394,5 @@
     my $SearchResult;
     if ( $SourceData->{ChangeSearch} ) {
-        $SearchResult = $Self->{ChangeObject}->ChangeSearch(
+        $SearchResult = $ChangeObject->ChangeSearch(
             %{ $SourceData->{ChangeSearch} },
         );
@@ -5432,5 +5432,5 @@
 # each of the changes should have one workorder
 for my $ChangeID (@WOStateTestChangeIDs) {
-    my $ChangeData = $Self->{ChangeObject}->ChangeGet(
+    my $ChangeData = $ChangeObject->ChangeGet(
         ChangeID => $ChangeID,
         UserID   => 1,
@@ -5717,6 +5717,6 @@
             my $Privs = $ReferenceData->{Permissions}->{$UserIndex};
             for my $Type ( keys %{$Privs} ) {
-                $Self->{ChangeObject}->{Debug} = 10;
-                my $Access = $Self->{ChangeObject}->Permission(
+                $ChangeObject->{Debug} = 10;
+                my $Access = $ChangeObject->Permission(
                     Type     => $Type,
                     ChangeID => $PermissionTestChangeID,
@@ -5752,5 +5752,5 @@
 
 # When no ChangeID is given ChangePossibleStatesGet() returns a list of all states.
-my $PossibleStates = $Self->{ChangeObject}->ChangePossibleStatesGet(
+my $PossibleStates = $ChangeObject->ChangePossibleStatesGet(
 
     #    ChangeID => $PossibleStatesTestChangeID,
@@ -5826,10 +5826,10 @@
 
 # Create a change object...
-my $ChangeIDForChangePossibleStateGet = $Self->{ChangeObject}->ChangeAdd(
+my $ChangeIDForChangePossibleStateGet = $ChangeObject->ChangeAdd(
     UserID => 1,
 );
 
 # Get posssible states...
-my $PossibleStatesUsingChangeID = $Self->{ChangeObject}->ChangePossibleStatesGet(
+my $PossibleStatesUsingChangeID = $ChangeObject->ChangePossibleStatesGet(
     ChangeID => $ChangeIDForChangePossibleStateGet,
     UserID   => 1,
@@ -5846,5 +5846,5 @@
 
 # Change the state
-my $ChangeUpdateSuccess = $Self->{ChangeObject}->ChangeUpdate(
+my $ChangeUpdateSuccess = $ChangeObject->ChangeUpdate(
     ChangeID    => $ChangeIDForChangePossibleStateGet,
     ChangeState => 'pending approval',
@@ -5860,5 +5860,5 @@
 
 # Get posssible states...
-$PossibleStatesUsingChangeID = $Self->{ChangeObject}->ChangePossibleStatesGet(
+$PossibleStatesUsingChangeID = $ChangeObject->ChangePossibleStatesGet(
     ChangeID => $ChangeIDForChangePossibleStateGet,
     UserID   => 1,
@@ -5873,5 +5873,5 @@
 
 # Change the state
-$ChangeUpdateSuccess = $Self->{ChangeObject}->ChangeUpdate(
+$ChangeUpdateSuccess = $ChangeObject->ChangeUpdate(
     ChangeID    => $ChangeIDForChangePossibleStateGet,
     ChangeState => 'approved',
@@ -5887,5 +5887,5 @@
 
 # Get posssible states...
-$PossibleStatesUsingChangeID = $Self->{ChangeObject}->ChangePossibleStatesGet(
+$PossibleStatesUsingChangeID = $ChangeObject->ChangePossibleStatesGet(
     ChangeID => $ChangeIDForChangePossibleStateGet,
     UserID   => 1,
@@ -5900,5 +5900,5 @@
 
 # Change the state
-$ChangeUpdateSuccess = $Self->{ChangeObject}->ChangeUpdate(
+$ChangeUpdateSuccess = $ChangeObject->ChangeUpdate(
     ChangeID    => $ChangeIDForChangePossibleStateGet,
     ChangeState => 'in progress',
@@ -5914,5 +5914,5 @@
 
 # Get posssible states...
-$PossibleStatesUsingChangeID = $Self->{ChangeObject}->ChangePossibleStatesGet(
+$PossibleStatesUsingChangeID = $ChangeObject->ChangePossibleStatesGet(
     ChangeID => $ChangeIDForChangePossibleStateGet,
     UserID   => 1,
@@ -5927,5 +5927,5 @@
 
 # Delete the Change
-$Self->{ChangeObject}->ChangeDelete(
+$ChangeObject->ChangeDelete(
     ChangeID => $ChangeIDForChangePossibleStateGet,
     UserID   => 1,
@@ -6043,5 +6043,5 @@
 # ------------------------------------------------------------ #
 
-$LookupOk = $Self->{ChangeObject}->ChangeCIPLookup(
+$LookupOk = $ChangeObject->ChangeCIPLookup(
     CIP  => '1 very high',
     Type => 'non-existent',
@@ -6053,5 +6053,5 @@
 );
 
-$LookupOk = $Self->{ChangeObject}->ChangeCIPLookup(
+$LookupOk = $ChangeObject->ChangeCIPLookup(
     CIP => '1 very high',
 );
@@ -6062,5 +6062,5 @@
 );
 
-$LookupOk = $Self->{ChangeObject}->ChangeCIPLookup(
+$LookupOk = $ChangeObject->ChangeCIPLookup(
     Type => 'Priority',
 );
@@ -6071,5 +6071,5 @@
 );
 
-$LookupOk = $Self->{ChangeObject}->ChangeCIPLookup(
+$LookupOk = $ChangeObject->ChangeCIPLookup(
     Type => 'Priority',
     CIP  => '1 very high',
@@ -6086,5 +6086,5 @@
 # ------------------------------------------------------------ #
 
-my $PossibleCIPGetOk = $Self->{ChangeObject}->ChangePossibleCIPGet(
+my $PossibleCIPGetOk = $ChangeObject->ChangePossibleCIPGet(
     Type   => 'non-existent',
     UserID => 1,
@@ -6096,5 +6096,5 @@
 );
 
-$PossibleCIPGetOk = $Self->{ChangeObject}->ChangePossibleCIPGet(
+$PossibleCIPGetOk = $ChangeObject->ChangePossibleCIPGet(
     UserID => 1,
 );
@@ -6108,5 +6108,5 @@
 my $PossibleCIPReference = join ', ', @CIPValues;
 for my $Type (qw(Category Impact Priority)) {
-    my $PossibleCIPs = $Self->{ChangeObject}->ChangePossibleCIPGet(
+    my $PossibleCIPs = $ChangeObject->ChangePossibleCIPGet(
         Type   => $Type,
         UserID => 1,
@@ -6133,5 +6133,5 @@
 
 # verify that initialy no attachment exists
-my @AttachmentList = $Self->{ChangeObject}->ChangeAttachmentList(
+my @AttachmentList = $ChangeObject->ChangeAttachmentList(
     ChangeID => $AttachmentTestChangeID,
 );
@@ -6161,5 +6161,5 @@
     $FileCount++;
 
-    my $AddOk = $Self->{ChangeObject}->ChangeAttachmentAdd(
+    my $AddOk = $ChangeObject->ChangeAttachmentAdd(
         %{$TestFile},
         ChangeID => $AttachmentTestChangeID,
@@ -6171,5 +6171,5 @@
     );
 
-    my @AttachmentList = $Self->{ChangeObject}->ChangeAttachmentList(
+    my @AttachmentList = $ChangeObject->ChangeAttachmentList(
         ChangeID => $AttachmentTestChangeID,
         UserID   => 1,
@@ -6189,5 +6189,5 @@
 
     # get the attachment
-    my $Attachment = $Self->{ChangeObject}->ChangeAttachmentGet(
+    my $Attachment = $ChangeObject->ChangeAttachmentGet(
         ChangeID => $AttachmentTestChangeID,
         Filename => $TestFile->{Filename},
@@ -6208,5 +6208,5 @@
 
     # check existence of attachment
-    my $AttachmentExists = $Self->{ChangeObject}->ChangeAttachmentExists(
+    my $AttachmentExists = $ChangeObject->ChangeAttachmentExists(
         ChangeID => $AttachmentTestChangeID,
         Filename => $TestFile->{Filename},
@@ -6227,5 +6227,5 @@
     $FileCount++;
 
-    my $DeleteOk = $Self->{ChangeObject}->ChangeAttachmentDelete(
+    my $DeleteOk = $ChangeObject->ChangeAttachmentDelete(
         ChangeID => $AttachmentTestChangeID,
         Filename => $TestFile->{Filename},
@@ -6237,5 +6237,5 @@
     );
 
-    my @AttachmentList = $Self->{ChangeObject}->ChangeAttachmentList(
+    my @AttachmentList = $ChangeObject->ChangeAttachmentList(
         ChangeID => $AttachmentTestChangeID,
         UserID   => 1,
@@ -6248,5 +6248,5 @@
     );
 
-    my $AttachmentExists = $Self->{ChangeObject}->ChangeAttachmentExists(
+    my $AttachmentExists = $ChangeObject->ChangeAttachmentExists(
         Filename => $TestFile->{Filename},
         ChangeID => $AttachmentTestChangeID,
@@ -6273,5 +6273,5 @@
 
     # add a new test change
-    my $ChangeID = $Self->{ChangeObject}->ChangeAdd(
+    my $ChangeID = $ChangeObject->ChangeAdd(
         %OldValues,
         UserID => 1,
@@ -6289,5 +6289,5 @@
 
     # update the change
-    my $Success = $Self->{ChangeObject}->ChangeUpdate(
+    my $Success = $ChangeObject->ChangeUpdate(
         %NewValues,
         ChangeID => $ChangeID,
@@ -6364,5 +6364,5 @@
 for my $ChangeID ( keys %TestedChangeID ) {
 
-    my $DeleteOk = $Self->{ChangeObject}->ChangeDelete(
+    my $DeleteOk = $ChangeObject->ChangeDelete(
         ChangeID => $ChangeID,
         UserID   => 1,
@@ -6374,5 +6374,5 @@
 
     # double check if change is really deleted
-    my $ChangeData = $Self->{ChangeObject}->ChangeGet(
+    my $ChangeData = $ChangeObject->ChangeGet(
         ChangeID => $ChangeID,
         UserID   => 1,
---------------------------------------------------------------------
OTRS mailing list: cvs-log - Webpage: http://otrs.org/
Archive: http://lists.otrs.org/pipermail/cvs-log
To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/cvs-log