Unused code?

Moritz Lenz <[email protected]> Tue, 4 Nov 2014 12:33:12 +0100
Newsgroups gmane.comp.otrs.devel
Message-ID <[email protected]>
Hi all,

Here:

https://github.com/OTRS/otrs/blob/bc9684d6e8baad693a8dada859b8f20af6cbcfff/Kernel/System/Ticket/Article.pm#L646

In Kernel::System::Ticket::Article there is this code:

    if (
                     $UserData{UserSendFollowUpNotification}
                     && $UserData{UserSendFollowUpNotification} == 2
                     && $Ticket{OwnerID} ne 1
                     && $Ticket{OwnerID} ne $Param{UserID}
                     && $Ticket{OwnerID} ne $UserData{UserID}
                     )
                 {

However the default preferences only allow UserSendFollowUpNotification 
to be 0 or 1 (or undef when not set).

Is this some undocumented feature? Or simply dead code that can be removed?

The code seems to come from 2005 originally: 
https://github.com/OTRS/otrs/commit/777b9c8225aeffd90bb7b3cef012cdd2ecbf798b

_______________________________________________
OTRS mailing list: dev - Webpage: http://otrs.org/
Archive: http://lists.otrs.org/pipermail/dev
To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev
smime.p7s (application/x-pkcs7-signature, 6.2 KB) - not displayed