Why is there a "new" and "run" in every module?

Niels Dimmers <[email protected]> Mon, 29 Feb 2016 15:21:38 +0000
Newsgroups gmane.comp.otrs.devel
Message-ID <CADCN-iQZi0cWV5a_ERued7gWfzNNKU0QUbY+52m6zxGDsnwrZA@mail.gmail.com>
--===============0803897367==
Content-Type: multipart/alternative; boundary=089e01177a231cf996052cea3518

--089e01177a231cf996052cea3518
Content-Type: text/plain; charset=UTF-8

Hi,

In an attempt to fix bug 8104 I am restructuring a lot of code in the
module AgentTicketZoom and the related toolbar packages (located in
Kernel/Output/HTML/ToolBar). I found that there's a "new" and "run" sub in
the module and in the display packages as well. Does anyone know why this
structure has been chosen? Isn't it far easier to use (get) and (set)
methods to get and set data?

I think it should be easier to let the model (Kernel/Output/HTML/ToolBar)
generate and/or supply the template, instead of doing this partly in the
contoller (AgentTicketZoom) and the template. I think the way it's
structured now requires a lot of extra code and a lot of processing power
whilst the same could be dealt with easier and cheaper. Do you have any
suggestions on this? Since it is *a lot* of work I thought about mailing
you first before applying such a broad restructure of the code.

Regards,

Niels

--089e01177a231cf996052cea3518
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div><div><div><div>Hi,<br><br></div>In an attempt to fix =
bug 8104 I am restructuring a lot of code in the module AgentTicketZoom and=
 the related toolbar packages (located in Kernel/Output/HTML/ToolBar). I fo=
und that there&#39;s a &quot;new&quot; and &quot;run&quot; sub in the modul=
e and in the display packages as well. Does anyone know why this structure =
has been chosen? Isn&#39;t it far easier to use (get) and (set) methods to =
get and set data?<br><br></div>I think it should be easier to let the model=
 (Kernel/Output/HTML/ToolBar) generate and/or supply the template, instead =
of doing this partly in the contoller (AgentTicketZoom) and the template. I=
 think the way it&#39;s structured now requires a lot of extra code and a l=
ot of processing power whilst the same could be dealt with easier and cheap=
er. Do you have any suggestions on this? Since it is *a lot* of work I thou=
ght about mailing you first before applying such a broad restructure of the=
 code.<br><br></div>Regards,<br><br></div>Niels<br></div>

--089e01177a231cf996052cea3518--

--===============0803897367==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
OTRS mailing list: dev - Webpage: http://otrs.org/
Archive: http://lists.otrs.org/pipermail/dev
To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev
--===============0803897367==--