Re: Error handling in OTRS
Martin Gruner <[email protected]> Wed, 30 Oct 2019 15:16:25 +0100
| Newsgroups | gmane.comp.otrs.devel |
|---|---|
| Message-ID | <[email protected]> |
--===============6874892490307492419== Content-Type: multipart/signed; boundary="Apple-Mail=_1543BEAB-6DD9-4894-B7DF-B16E8E61277A"; protocol="application/pkcs7-signature"; micalg=sha-256 --Apple-Mail=_1543BEAB-6DD9-4894-B7DF-B16E8E61277A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hello =D0=AE=D1=80=D0=B8=D0=B9. You are right! There are many places in the OTRS backend code like this. = Unfortunately this is not an easy change at hand. We are currently = focusing on a rewrite of the frontend with modern technology. This will = already replace much legacy code. The backend will follow later. Best regards, Martin Gruner Team Lead R&D OTRS AG Bahnhofplatz 1a 94315 Straubing T: +49 6172 681988-0 F: +49 9421 56818-18 I: https://www.otrs.com/ Gesch=C3=A4ftssitz: Bad Homburg, Amtsgericht: Bad Homburg, HRB 10751, = USt-Nr.: DE256610065 Aufsichtsratsvorsitzender: Burchard Steinbild, Vorstand: Andr=C3=A9 = Mindermann (Vorsitzender), Christopher Kuhn, Sabine Riedel ____________________________________________________ OTRS 7 | Automation =E2=80=A2 Agilit=C3=A4t =E2=80=A2 Kommunikation =E2=80= =A2 Transparenz https://otrs.com/de/otrs-7/ OTRS ist SERVIEW CERTIFIEDTOOL. > Am 23.10.2019 um 15:50 schrieb =D0=AE=D1=80=D0=B8=D0=B9 = =D0=9C=D1=8F=D1=81=D0=BE=D0=B5=D0=B4=D0=BE=D0=B2 = <[email protected]>: >=20 > Hello, OTRS devs! >=20 > It seems there is a fundamental flaw of error handling in OTRS. > Currently, many subroutines (methods) use "return;" when something > goes wrong. > It's okay but "return;" returns undef in scalar context and empty list > in list context. >=20 > Let me show a problem: >=20 > my %PID =3D $PIDObject->PIDGet( > Name =3D> 'PostMasterPOP3', > ); >=20 > Ok. Let's assume now that your %PID is empty. But why it's empty? > Because there is no such PID or because you've got an error (some DB > error for example)? There is no any error flags or something, what you > can check. > _______________________________________________ > OTRS mailing list: dev - Webpage: http://otrs.org/ > Archive: http://lists.otrs.org/pipermail/dev > To unsubscribe: http://lists.otrs.org/mailman/listinfo/dev >=20 --Apple-Mail=_1543BEAB-6DD9-4894-B7DF-B16E8E61277A Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCC7ow ggVkMIIETKADAgECAhAN3zPzS8fppWYFhNgFzPa2MA0GCSqGSIb3DQEBCwUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IFNIQTIgQXNzdXJlZCBJRCBDQTAeFw0xODA1MjgwMDAwMDBaFw0yMTA1 MjgxMjAwMDBaMIGDMQswCQYDVQQGEwJERTEPMA0GA1UECBMGSGVzc2VuMRIwEAYDVQQHEwlPYmVy dXJzZWwxEDAOBgNVBAoTB09UUlMgQUcxFjAUBgNVBAMTDU1hcnRpbiBHcnVuZXIxJTAjBgkqhkiG 9w0BCQEWFm1hcnRpbi5ncnVuZXJAb3Rycy5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEK AoIBAQC6SOWZRA24Kf2jwmoXRX9epuMKgL5E6d6FP8s/nNGztNhH4dNKYvw6aujqXiqgRIkZPU8/ aGMvsHw7OdBFFsucIXqEnYxum90cQzGFpy9u5xYZ+7pucmgoCx+X99XOaFoJq/MYpfO8uR2bJRQs hob/z4s4RX4BBi6r7VBOSeBI78O/snvABdD+HBAKE1dqkdigEYt4OhJFif/+oVP6ID1NjIZaYj4C KKXu1c2ahvBjKUKRVWqCyvZ/+R+peNd6tp8WbARbSggybWjp5sOikQOS+YjIGAFBwcUludPOTkT8 morkZIEXeS64yx61qSXHhnEJJz7LIkzhD9QCZL0skUHHAgMBAAGjggHvMIIB6zAfBgNVHSMEGDAW gBTnAiOAAE/Y17yUC9k/dDlJMjyKeTAdBgNVHQ4EFgQUoxx1KGUkXuVE9vEIe5PZKJD6HYEwDAYD VR0TAQH/BAIwADAhBgNVHREEGjAYgRZtYXJ0aW4uZ3J1bmVyQG90cnMuY29tMA4GA1UdDwEB/wQE AwIFoDAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwQwYDVR0gBDwwOjA4BgpghkgBhv1s BAECMCowKAYIKwYBBQUHAgEWHGh0dHBzOi8vd3d3LmRpZ2ljZXJ0LmNvbS9DUFMwgYgGA1UdHwSB gDB+MD2gO6A5hjdodHRwOi8vY3JsMy5kaWdpY2VydC5jb20vRGlnaUNlcnRTSEEyQXNzdXJlZElE Q0EtZzIuY3JsMD2gO6A5hjdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRTSEEyQXNz dXJlZElEQ0EtZzIuY3JsMHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3Au ZGlnaWNlcnQuY29tMEMGCCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGln aUNlcnRTSEEyQXNzdXJlZElEQ0EuY3J0MA0GCSqGSIb3DQEBCwUAA4IBAQB6LQ1/vZN9J0DgcPcp zYToG7vDF6FR4zTkbcHCDMLod25ayuehFPnX4N+DC09jPtu4Q0MlPsJU+6T4BbkAEOWi2U8gQXr1 D2xujDCM+P518eis2FeetgZueHnD8vuVg32RblTpxQ9iucy5zGsfQSbQMpxW22j4lI4Pz4lY2LKu 4ZMXoJeSJElu/viIjAT7RXqVto9OPt9PbxwvXLzZ5zoGWEeodiAG4JD6nxc+PiZW1BzfuFnsJFK9 v9T4zQefDunrynmNJGH9E/JxdV6y1xGwp+Dw3NBGv1ga76tnlN05M8qoWxVW4EcsxeRUcP30susF CbOEEB04SnT0IVyBu4ltMIIGTjCCBTagAwIBAgIQBK55YGZmkBq5xX+mbFvczTANBgkqhkiG9w0B AQsFADBlMQswCQYDVQQGEwJVUzEVMBMGA1UEChMMRGlnaUNlcnQgSW5jMRkwFwYDVQQLExB3d3cu ZGlnaWNlcnQuY29tMSQwIgYDVQQDExtEaWdpQ2VydCBBc3N1cmVkIElEIFJvb3QgQ0EwHhcNMTMx MTA1MTIwMDAwWhcNMjgxMTA1MTIwMDAwWjBlMQswCQYDVQQGEwJVUzEVMBMGA1UEChMMRGlnaUNl cnQgSW5jMRkwFwYDVQQLExB3d3cuZGlnaWNlcnQuY29tMSQwIgYDVQQDExtEaWdpQ2VydCBTSEEy IEFzc3VyZWQgSUQgQ0EwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDc+BEjP2q178An eRstBYeiEEMx3w7UFRtPd6Qizj6McPC+B47dJyq8AR22LArK3WlYH0HtagUf2mN4WR4iLCv4un7J NTtW8R98Qn4lsCMZxkU41z1E+SB8YK4csFoYBL6PO/ep8JSapgxjSbZBF1NAMr1P5lB6UB8lRejx ia/N/17/UPPwFxH/vcWJ9b1iudj7jkUEhW2ZzcVITf0mqwI2Reo2119q4hqCQQrc6dn1kReOxiGt ODwT5h5/ZpzVTdlG2vbPUqd9OyTDtMFRNcab69TvfuR7A+FEvXoLN+BPy4KKDXEY5KbgiSwb87Jz PMGwkp4Yfb2rfcV9CKEswp9zAgMBAAGjggL4MIIC9DASBgNVHRMBAf8ECDAGAQH/AgEAMA4GA1Ud DwEB/wQEAwIBhjA0BggrBgEFBQcBAQQoMCYwJAYIKwYBBQUHMAGGGGh0dHA6Ly9vY3NwLmRpZ2lj ZXJ0LmNvbTCBgQYDVR0fBHoweDA6oDigNoY0aHR0cDovL2NybDQuZGlnaWNlcnQuY29tL0RpZ2lD ZXJ0QXNzdXJlZElEUm9vdENBLmNybDA6oDigNoY0aHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0Rp Z2lDZXJ0QXNzdXJlZElEUm9vdENBLmNybDAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQw ggGzBgNVHSAEggGqMIIBpjCCAaIGCmCGSAGG/WwAAgQwggGSMCgGCCsGAQUFBwIBFhxodHRwczov L3d3dy5kaWdpY2VydC5jb20vQ1BTMIIBZAYIKwYBBQUHAgIwggFWHoIBUgBBAG4AeQAgAHUAcwBl ACAAbwBmACAAdABoAGkAcwAgAEMAZQByAHQAaQBmAGkAYwBhAHQAZQAgAGMAbwBuAHMAdABpAHQA dQB0AGUAcwAgAGEAYwBjAGUAcAB0AGEAbgBjAGUAIABvAGYAIAB0AGgAZQAgAEQAaQBnAGkAQwBl AHIAdAAgAEMAUAAvAEMAUABTACAAYQBuAGQAIAB0AGgAZQAgAFIAZQBsAHkAaQBuAGcAIABQAGEA cgB0AHkAIABBAGcAcgBlAGUAbQBlAG4AdAAgAHcAaABpAGMAaAAgAGwAaQBtAGkAdAAgAGwAaQBh AGIAaQBsAGkAdAB5ACAAYQBuAGQAIABhAHIAZQAgAGkAbgBjAG8AcgBwAG8AcgBhAHQAZQBkACAA aABlAHIAZQBpAG4AIABiAHkAIAByAGUAZgBlAHIAZQBuAGMAZQAuMB0GA1UdDgQWBBTnAiOAAE/Y 17yUC9k/dDlJMjyKeTAfBgNVHSMEGDAWgBRF66Kv9JLLgjEtUYunpyGd823IDzANBgkqhkiG9w0B AQsFAAOCAQEATtSJJ7n9HYd3fg8oBZDxCi/JOz69k5yQxq/6kVGHMlRr6MrBcVFcmY61+uBiGZmm B5p8Eyfb5QKihBLZFfYKRFfENI9tcx861qABPd7jguRFa7LrJf2AXh05kL5bQvbOkWDj+aBWDEgQ zjNoe82Tq/Bqy09YD7l7XRsEgZ6nIuJXSSfukpMIvmkIUwI6Ll3IGfRQgE4C2bBdkbSTh/mWloFV QI5m7YLYuyhf7Uxh7QZYKBlTEUS8RyApsgRs2IlUmTt122d4LB6SeMZVPVgSETJuvUMMTTTbe8ZC 2+y+q5thTAaS447fISpQVwTAYKI11SSeZjcJSc/V+GWz4OJuwjGCAykwggMlAgEBMHkwZTELMAkG A1UEBhMCVVMxFTATBgNVBAoTDERpZ2lDZXJ0IEluYzEZMBcGA1UECxMQd3d3LmRpZ2ljZXJ0LmNv bTEkMCIGA1UEAxMbRGlnaUNlcnQgU0hBMiBBc3N1cmVkIElEIENBAhAN3zPzS8fppWYFhNgFzPa2 MA0GCWCGSAFlAwQCAQUAoIIBgTAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0xOTEwMzAxNDE2MjVaMC8GCSqGSIb3DQEJBDEiBCAarI7mpSjxkbXSd3fTDBu2GUVoFjC2 uLYZAqJaaQuJtzCBiAYJKwYBBAGCNxAEMXsweTBlMQswCQYDVQQGEwJVUzEVMBMGA1UEChMMRGln aUNlcnQgSW5jMRkwFwYDVQQLExB3d3cuZGlnaWNlcnQuY29tMSQwIgYDVQQDExtEaWdpQ2VydCBT SEEyIEFzc3VyZWQgSUQgQ0ECEA3fM/NLx+mlZgWE2AXM9rYwgYoGCyqGSIb3DQEJEAILMXugeTBl MQswCQYDVQQGEwJVUzEVMBMGA1UEChMMRGlnaUNlcnQgSW5jMRkwFwYDVQQLExB3d3cuZGlnaWNl cnQuY29tMSQwIgYDVQQDExtEaWdpQ2VydCBTSEEyIEFzc3VyZWQgSUQgQ0ECEA3fM/NLx+mlZgWE 2AXM9rYwDQYJKoZIhvcNAQEBBQAEggEAAGe4OdFV7UodR3TOAbNGHQ3W/i4GKbUj3oocDJgRYEef sDBpybjBVuOzc86LSIsSnEu860Wh45IKK3fssfgJYLXvtvfm89cw3N7sldbJRPfm4jymO2y+BGXl 1nniicIEN+DLipyHYhQZ98Ofs3FPe8WTRnp0LJ1kd9nd+kkTQYMJwo7LSHRpZpke1j3z0TLsb3Hi aPpcs97uc4iuB50yf5VddJfgpR339SFdH9mKVe4mrgdaQ3b1+4wege1dP1ryexfnObM2emmqqa65 GjNwa2pCTr5iX5d9Pr8cZn59dbFWoButM+iCgBjaXnOsjuVuz97bZoSiZChzp3liSCmTZgAAAAAA AA== --Apple-Mail=_1543BEAB-6DD9-4894-B7DF-B16E8E61277A-- --===============6874892490307492419== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ OTRS mailing list: dev - Webpage: http://otrs.org/ Archive: http://lists.otrs.org/pipermail/dev To unsubscribe: http://lists.otrs.org/mailman/listinfo/dev --===============6874892490307492419==--