Re: C++: Pointer to non-const std::string in position and location should be a pointer to const std::string
Akim Demaille <[email protected]>
| Newsgroups | gmane.comp.parsers.bison.bugs |
|---|---|
| Message-ID | <[email protected]> |
Hi Jacob, > Le 27 juin 2020 à 16:18, Jacob L. Mandelson <[email protected]> a écrit : > > On Sat, Jun 27, 2020 at 10:08:05AM +0200, Akim Demaille wrote: > [...] >> +*** File prefix mapping >> + >> + Bison learned a new argument, '--file-prefix-map OLD=NEW'. Any file path in >> + the output (specifically #line directives and #ifdef header guards) that >> + being with the prefix OLD will have it replace with the prefix NEW, similar > > > Surely you mean "begin", not "being". Though you'll actually want "begins" > to agree with the singular subject "path", and also "replaced" since it's > passive. Thanks a lot for catching this. I'll install the appended fix. > Be well, > -- Jacob, addressing the other kind of grammar :) commit d796e11f8f7d459408824f0d2c8174e3f4715f84 Author: Akim Demaille <[email protected]> Date: Sat Jun 27 17:03:28 2020 +0200 news: fixes Reported by Jacob L. Mandelson. * NEWS: here. diff --git a/NEWS b/NEWS index 29425bca..82636252 100644 --- a/NEWS +++ b/NEWS @@ -6,11 +6,11 @@ GNU Bison NEWS *** File prefix mapping - Bison learned a new argument, '--file-prefix-map OLD=NEW'. Any file path in - the output (specifically #line directives and #ifdef header guards) that - being with the prefix OLD will have it replace with the prefix NEW, similar - to the -ffile-prefix-map in GCC. This option can be used to make bison output - reproducible. + Bison learned a new argument, `--file-prefix-map OLD=NEW`. Any file path + in the output (specifically `#line` directives and `#ifdef` header guards) + that begins with the prefix OLD will have it replaced with the prefix NEW, + similar to the `-ffile-prefix-map` in GCC. This option can be used to + make bison output reproducible. ** Changes diff --git a/THANKS b/THANKS index e9bc2762..e38e3613 100644 --- a/THANKS +++ b/THANKS @@ -84,6 +84,7 @@ Guido Trentalancia [email protected] H. Merijn Brand [email protected] Hans Åberg [email protected] Horst Von Brand [email protected] +Jacob L. Mandelson [email protected] Jan Nieuwenhuizen [email protected] Jannick [email protected] Jeff Hammond [email protected]