Re: [PATCH] cex: fix leaks
Akim Demaille <[email protected]>
| Newsgroups | gmane.comp.parsers.bison.patches |
|---|---|
| Message-ID | <[email protected]> |
Hi Vincent! > Le 18 mai 2020 à 14:23, [email protected] a écrit : > > > Hey Akim, > >> I think we should at least use typedef to clarify what different types of list exist (e.g., parse_state_list_t). > I like this idea a lot. Good, let's go for it. I won't do that now, but many tomorrow in the morning. > I also think changing the hash maps to bitset vectors is fine; I initially didn’t want to since I knew they could be pretty sparse. Then, instead of a bitsetv, a table of malloced bitsets should do it. It might be sparse, but on a quite compact range, isn't it? > I’ll look at the leak tonight. I have an idea where one should be coming from but I didn’t really get the chance to look yesterday. No worries, you already did wonders :)