Re: [PATCH] src: make path to m4 relocatable
Thomas Petazzoni <[email protected]>
| Newsgroups | gmane.comp.parsers.bison.patches |
|---|---|
| Organization | Bootlin |
| Message-ID | <[email protected]> |
Hello Akim, On Tue, 19 May 2020 08:14:07 +0200 Akim Demaille <[email protected]> wrote: > Good point. > > > The patch is not right though: you are *forced* to have relocated m4 for > this patch to work: if you moved only your install tree of bison, it looks > for m4 there. > > You should check that a relocated m4 is available, and then fallback to > M4 again. > > You also have minor stylistic issues. Thanks for the review. You're indeed right. I'll respin a v2 shortly. Thanks, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com