Re: [PATCH 0/7] Fixing all cex leaks
Akim Demaille <[email protected]>
| Newsgroups | gmane.comp.parsers.bison.patches |
|---|---|
| Message-ID | <[email protected]> |
Hi Vincent! > Le 22 mai 2020 à 04:13, Vincent Imbimbo <[email protected]> a écrit : > > Hey Akim, > I think I got all of them. I ended up implementing some of the stuff we discussed to fix these. > The state-item graph edges are now kept in the structs. I also added typedefs / API for derivation_list and parse_state_list. I saw that. That's great! I'm pushing this right now to the CI, we should have the answer soon: https://travis-ci.org/github/akimd/bison/builds/689920732. But maybe I will have pushed again before you actual check: please look for the latest (leftmost) build of the cex branch here: https://travis-ci.org/github/akimd/bison/branches. This is great stuff! FYI, I have fixed some of your commit messages for a few issues: - fit into 80 cols - the colon is after the parentheses, not before - repeat the * when the list of files wraps because of the width limit * src/counterexample.c: (unifying_counterexample) always free stage3result when it exists. => * src/counterexample.c (unifying_counterexample): Always free stage3result when it exists. Cheers!