Re: cex: clean the display of conflicted symbols

Akim Demaille <[email protected]>
Newsgroups gmane.comp.parsers.bison.patches
Message-ID <[email protected]>

> Le 23 mai 2020 à 18:23, Akim Demaille <[email protected]> a écrit :
> 
> commit 1ec93ca2a2b4718b5d94871475520a2688b4c5c8
> Author: Akim Demaille <[email protected]>
> Date:   Sat May 23 18:17:57 2020 +0200
> 
>    cex: clean the display of conflicted symbols
> 
>    Instead of `On Symbols: {b,c,}`, display `On Symbols: b, c`.
> 
>    * src/counterexample.c (counterexample_report_reduce_reduce): We don't
>    need braces.
>    Use commas as a separator, not a terminator.
>    * tests/counterexample.at: Adjust.

For some reasons I managed to miss some cases.  Apologies.

commit 6ed813c122a5a52986f34d2d387223ec3af49c57
Author: Akim Demaille <[email protected]>
Date:   Sun May 24 15:16:15 2020 +0200

    tests: fix expectations
    
    Should have been part of 1ec93ca2a2b4718b5d94871475520a2688b4c5c8.
    
    * tests/counterexample.at: here.

diff --git a/tests/counterexample.at b/tests/counterexample.at
index 6cddb501..d8582000 100644
--- a/tests/counterexample.at
+++ b/tests/counterexample.at
@@ -440,7 +440,7 @@ Second derivation  $accept ::=[ a ::=[ c ::=[ • ]  d ::=[ c  A  A ] ]  $end ]
 Reduce-Reduce Conflict:
 2:    3 b: . %empty
 2:    4 c: . %empty
-On Symbols: {A,}
+On Symbols: A
 time limit exceeded: 6.000000
 First  Example b  •  c  A  A  $end
 First  derivation  $accept ::=[ a ::=[ b  d ::=[ a ::=[ b ::=[ • ]  d ::=[ c  A  A ] ] ] ]  $end ]
@@ -450,7 +450,7 @@ Second derivation  $accept ::=[ a ::=[ b  d ::=[ c ::=[ • ]  A ] ]  $end ]
 Reduce-Reduce Conflict:
 3:    3 b: . %empty
 3:    4 c: . %empty
-On Symbols: {A,}
+On Symbols: A
 time limit exceeded: 6.000000
 First  Example c  •  c  A  A  $end
 First  derivation  $accept ::=[ a ::=[ c  d ::=[ a ::=[ b ::=[ • ]  d ::=[ c  A  A ] ] ] ]  $end ]
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.