Re: [PATCH] style: decouple different uses of item_number

Vincent Imbimbo <[email protected]>
Newsgroups gmane.comp.parsers.bison.patches
Message-ID <CANGxML5sgsz=21_yiz476dAt_bbo5asboDV4-AHbBz=+Hd4C7w@mail.gmail.com>
Hey Akim,

I'm confused about these item_indices you've changed to item_number, since
state->items is an array of item_indices.


> diff --git a/src/ielr.c b/src/ielr.c
> index f86cd461..47ac714a 100644
> --- a/src/ielr.c
> +++ b/src/ielr.c
> @@ -1030,7 +1030,7 @@ ielr_split_states (bitsetv follow_kernel_items,
> bitsetv always_follows,
>          if (!node->state->consistent)
>            {
>              size_t i = 0;
> -            item_number *itemset = node->state->items;
> +            item_index *itemset = node->state->items;
>              for (size_t r = 0; r < node->state->reductions->num; ++r)
>                {
>                  rule *this_rule = node->state->reductions->rules[r];
> diff --git a/src/print-xml.c b/src/print-xml.c
> index a44af211..168d6bd5 100644
> --- a/src/print-xml.c
> +++ b/src/print-xml.c
> @@ -57,7 +57,7 @@ static struct escape_buf escape_bufs[num_escape_bufs];
>  static void
>  print_core (FILE *out, int level, state *s)
>  {
> -  item_number *sitems = s->items;
> +  item_index *sitems = s->items;
>    size_t snritems = s->nitems;
>
>    /* Output all the items of a state, not only its kernel.  */
> diff --git a/src/print.c b/src/print.c
> index 720740ee..1da0f9dd 100644
> --- a/src/print.c
> +++ b/src/print.c
> @@ -61,7 +61,7 @@ max_length (size_t *width, const char *str)
>  static void
>  print_core (FILE *out, state *s)
>  {
> -  item_number *sitems = s->items;
> +  item_index *sitems = s->items;
>    size_t snritems = s->nitems;
>    /* Output all the items of a state, not only its kernel.  */
>    if (report_flag & report_itemsets)
>
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.