Re: Bug in qi::symbols::find

Joel de Guzman <[email protected]> Tue, 17 Nov 2009 23:18:04 +0800
Newsgroups gmane.comp.parsers.spirit.devel
Message-ID <[email protected]>
Joel de Guzman wrote:
> Daniel James wrote:
>> 2009/11/17 Francois Barel <[email protected]>:
>>> As far as I understand, the previous behavior was that
>>> qi::symbols::find behaved like qi::parse: it returned a match when a
>>> full symbol was found at the beginning of the input (but without
>>> checking that the full input was matched). That means if you required
>>> a full match, you had to check for begin == end yourself afterwards
>>> (as for qi::parse).
>> The spirit 2 find has a string parameter so you can't do that. It's
>> also documented as matching the symbol, which is why I saw that as a
>> bug fix rather than an interface change.
>>
>> http://spirit.sourceforge.net/home/spirit2/libs/spirit/doc/html/spirit/qi/reference/string/symbols.html#spirit.qi.reference.string.symbols.expression_semantics
> 
> Not a show stopper, IMO. Please add a changelist item to make
> sure this quirk gets documented. While you are on it, it's
> best to add 'prefix_find' too.

Ah and lastly, it's my fault for not testing this. Please do
add some tests. Thanks!

Regards,
-- 
Joel de Guzman
http://www.boostpro.com
http://spirit.sf.net
http://www.facebook.com/djowel

Meet me at BoostCon
http://www.boostcon.com/home
http://www.facebook.com/boostcon



------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july