Re: Single element attributes in X3 "still" broken?
Joel de Guzman <[email protected]>
| Newsgroups | gmane.comp.parsers.spirit.general |
|---|---|
| Message-ID | <[email protected]> |
On 12/24/15 6:52 AM, Joel de Guzman wrote: > On 12/23/15 7:50 AM, Joel de Guzman wrote: >> On 12/14/15 10:03 AM, Seth wrote: >> The problem seems to be with parse_sequence partition_attribute. Somehow, it is passing >> inner to the rule instead of outer. I think partition_attribute is trying to be smart >> and unwraps the single-element sequence in pass_sequence_attribute_used (line 107 >> operator/detail/sequence.hpp). I think this pertains to rules, in particular, and >> parsers that has Parser::is_pass_through_unary == false, in general. >> >> Whether that is unwanted or not is the basic *design* question! There's a reason >> for its existence: partition-sequence itself may produce this one-element >> sequence by the very act of partitioning. Perhaps one solution is to *ONLY* >> do the unwrapping if the single-element sequence comes from partitioning, >> or is intended by the user. >> >> I've ran out of time today. I'll get back to it again while it's still fresh. >> In the meantime, if anyone has a better understanding and solution, that would >> be very welcome! C'mon and get dirty with some X3 hacking! > > OK, the solution I mentioned above seems to be working fine! I'll go run the > full regression tests to make sure nothing is broken and push the fix to develop. This 'fix' is now in develop. Regards, -- Joel de Guzman http://www.ciere.com http://boost-spirit.com http://www.cycfi.com/ ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140