Re: Community Poll: What do you think about qi supporting n-ary operators?

Larry Evans <[email protected]> wrote on 06.08.2016 20:31:19:

> From: Larry Evans <[email protected]>
> To: [email protected], 
> Date: 06.08.2016 20:33
> Subject: Re: [Spirit-general] Community Poll: What do you think 
> about qi supporting n-ary operators?
> 
> On 08/06/2016 10:43 AM, Frank Hein wrote:
> >
> >
> >> Am 06.08.2016 um 17:25 schrieb Larry Evans 
<[email protected]>:
> [snip]
> >> Hi Frank,
> >>
> >> After a brief look, it looks promising; however, the code here:
> >>
> >>
> > https://github.com/mxc-commons/MxcQitoo/blob/master/mxc/mxc/qitoo/
> operator/list2.hpp
> >>
> >> contains tabs, ....
> [snip]
> > Hi Larry,
> >
> > I'll change that.
> >
> > But please forget about qitoo for the moment. It's about the PR for qi
> > your oppinion would be valuable.
> >
> > The Develop Branch of my fork of Spirit has the implementation. 
Without
> > tabs anywhere, of course. :) Link is in the orig post.
> [snip]
> OOPS.  Sorry, I missed that.
> I did got to:
> 
> https://github.com/boostorg/spirit/pull/200
> 
> and clicked on the mxc-commons:develop phrase highlighted there
> but that was not a link; hence, I went to:
> 
> https://github.com/mxc-commons
> 
> where I found the MxcQitoo link.  So, that's where I went wrong.
> I suspect other's will go wrong for same reason.
> Maybe you could make the link to actual code more obvious
> somehow?  As you said, it was in the original post; however,
> it was buried toward last of post.
> --{--cut here--
> This is actually
> the feature branch for this PR (I learned somewhat late about branching
> https://github.com/mxc-commons/spirit
> --}--cut here--
> 
> -regards,
> Larry
> 

Larry, I corrected the things you mentioned. Thank you.

Just to make sure we have a common understanding of what this poll is all 
about:

To contribute to qi, I had to create a fork of boostorg/spirit. This fork
is mxc-commons/spirit. New features, bug fixes etc I can do in my fork.
This does not change anything to boostorg/spirit.

When I think, something is good enough and valuable enough I propose it
to Joel by creating a so called Pull Request. Having that done, the new
code is still not part of qi. Joel now can accept or reject the pull
request. Only if he accepted it would get part of qi.

Current status: I implemented and tested an extension to qi, which enables
support for n-ary operators. I created a pull request for that. The pull
request is not accepted yet. https://github.com/boostorg/spirit/pull/200 

As long as the PR is not accepted, this feature will not be part of qi.
If it would get accepted, qi would get the feature. The magic of Github
Pull Requests makes this happen.

If you read the comments, Joel asked me to drum for support. He wants to
know, if the community would like have this feature in qi.

That's what the poll is about. Do you think, qi should support n-ary
operator parser? Should this feature be added to qi? If yes, why? 
If no, why not? Do you have an oppinion to that you want to share?

Regards, Frank

------------------------------------------------------------------------------

_______________________________________________
Spirit-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spirit-general