Re: Spirit-X3 | Boost 1.59 | Compilation never finishes for a recursive grammar

On 25-05-17 20:35, Larry Evans wrote:
> On 04/21/2017 02:29 PM, Seth wrote:
>> On 21-04-17 20:25, Arun Muralidharan wrote:
>>> >From the attachment you provided, it appears to me that you have
>>> applied
>>> some sort patch. Is that correct ? I could not get that to compile
>>> on my
>>> machine by just defining "BOOST_SPIRIT_GET_RHS_CRTP=1".
>>
>> Without further checking, I assume the "patch" is to use latest version
>> of X3
>>
> As shown by:
>
>   https://github.com/cppljevans/spirit/tree/get_rhs
>
> it is now up-to-date with develop branch of:
>
>   https://github.com/boostorg/spirit
>
It is not clear to me what you mean with "up-to-date" in the context of
this question. It looks different to me. What more, it's 50 files in 49
commits. Who's gonna review that for impact? If you have a singular
issue to fix, that merits a single pull-request with either a very
isolated set of commit or a darn good discussion of the design changes.

If you want to get things merged, the best thing would be if you had
agreed on the design changes along the way, and pull requests are
excellent devices to get this discussion transparently on the board.

To me it looks like you have a private fork of X3, that you find useful.
I wouldn't suggest people to start using that fork unless there is
consensus on the way forward.

Seth

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot