[pear/DB] eeb1c7: DB::apiVersion() should be declared as static

"Armin Graefe via pear-cvs" <[email protected]> Sat, 04 Nov 2023 14:06:04 -0700
Newsgroups gmane.comp.php.cvs.pear
Message-ID <pear/DB/push/refs/heads/trunk/[email protected]>
  Branch: refs/heads/trunk
  Home:   https://github.com/pear/DB
  Commit: eeb1c7b772390bed5ba3aedcccfc1c8149635305
      https://github.com/pear/DB/commit/eeb1c7b772390bed5ba3aedcccfc1c8149635305
  Author: Mark Clements <[email protected]>
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
    M DB.php

  Log Message:
  -----------
  DB::apiVersion() should be declared as static

The DB class is designed to be called statically, but for some reason the apiVersion() method is not declared as such.

This will result in deprecation notices on PHP 7 and fatal errors on PHP 8, where it is no longer permitted to call non-static functions statically.

Note that this change will not break any misbehaving code that is instantiating the DB class in order to call this method - it is quite acceptable to call a static function on an object instance.


  Commit: c4a9ae0b1c3a4bb2a70258747b2a20d1bc76703b
      https://github.com/pear/DB/commit/c4a9ae0b1c3a4bb2a70258747b2a20d1bc76703b
  Author: Armin Graefe <[email protected]>
  Date:   2023-11-04 (Sat, 04 Nov 2023)

  Changed paths:
    M DB.php

  Log Message:
  -----------
  Merge pull request #17 from MarkMaldaba/php8/apiVersion

DB::apiVersion() should be declared as static


Compare: https://github.com/pear/DB/compare/90010c56379b...c4a9ae0b1c3a

-- 
PEAR CVS Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php