Re: cvs: ZendEngine2(PHP_5_3) / zend_builtin_functions.c

Hi Felipe,

Are you going to fix broken tests?

Test is_a() function : error conditions - wrong number of args
[ext/standard/tests/class_object/is_a_error_001.phpt]
Test is_a() function : usage variations  - wrong type for arg 1
[ext/standard/tests/class_object/is_a_variation_001.phpt]
Test is_a() function : usage variations  - wrong type for arg 2
[ext/standard/tests/class_object/is_a_variation_002.phpt]
Test is_a() function : usage variations  - case sensitivity
[ext/standard/tests/class_object/is_a_variation_003.phpt]

Thanks. Dmitry.

Felipe Pena wrote:
> felipe		Wed Jun 25 22:35:31 2008 UTC
> 
>   Modified files:              (Branch: PHP_5_3)
>     /ZendEngine2	zend_builtin_functions.c 
>   Log:
>   - Removed E_DEPRECATED on is_a()
>     (http://marc.info/?l=php-internals&m=121390431523970&w=2)
>   [doc]
>   
>   
> http://cvs.php.net/viewvc.cgi/ZendEngine2/zend_builtin_functions.c?r1=1.277.2.12.2.25.2.19&r2=1.277.2.12.2.25.2.20&diff_format=u
> Index: ZendEngine2/zend_builtin_functions.c
> diff -u ZendEngine2/zend_builtin_functions.c:1.277.2.12.2.25.2.19 ZendEngine2/zend_builtin_functions.c:1.277.2.12.2.25.2.20
> --- ZendEngine2/zend_builtin_functions.c:1.277.2.12.2.25.2.19	Thu Jun 19 11:27:41 2008
> +++ ZendEngine2/zend_builtin_functions.c	Wed Jun 25 22:35:31 2008
> @@ -17,7 +17,7 @@
>     +----------------------------------------------------------------------+
>  */
>  
> -/* $Id: zend_builtin_functions.c,v 1.277.2.12.2.25.2.19 2008/06/19 11:27:41 dmitry Exp $ */
> +/* $Id: zend_builtin_functions.c,v 1.277.2.12.2.25.2.20 2008/06/25 22:35:31 felipe Exp $ */
>  
>  #include "zend.h"
>  #include "zend_API.h"
> @@ -722,7 +722,6 @@
>     Returns true if the object is of this class or has this class as one of its parents */
>  ZEND_FUNCTION(is_a)
>  {
> -	zend_error(E_DEPRECATED, "is_a(): Deprecated. Please use the instanceof operator");
>  	is_a_impl(INTERNAL_FUNCTION_PARAM_PASSTHRU, 0);
>  }
>  /* }}} */
> 
> 
> 

-- 
Zend Engine CVS Mailing List (http://cvs.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php