Re: cvs: ZendEngine2(PHP_5_3) / Zend.m4 zend.c zend_compile.c zend_globals.h zend_highlight.c zend_language_scanner.c zend_language_scanner.h zend_language_scanner.l zend_language_scanner_defs.h zend_multibyte.h

Hello Jani,

I updated zend_language_scanner.l.

The tests stuff for zend-multibyte are already existing
in Zend/tests/multibyte/*.phpt.

In my understanding, the reason of removing zend_multibyte stuff 
from PHP 5.3 is incompatibility with re2c.

Removing multibyte encoding support from PHP 5.3 will cause
the severe incompatibility problem with the older PHP 5.x.

Rui

On Sun, 29 Jun 2008 13:49:38 +0300
Jani Taskinen <[email protected]> wrote:

> I think you should have committed the generated file (zend_language_scanner.c) 
> after the .l file commit. Second thing: The tests? This whole thing was removed 
> due to no actual tests that would have shown what this actually does. :)
> 
> --Jani
> 
> 
> Rui Hirokawa kirjoitti:
> > hirokawa		Sun Jun 29 08:21:36 2008 UTC
> > 
> >   Modified files:              (Branch: PHP_5_3)
> >     /ZendEngine2	Zend.m4 zend.c zend_compile.c zend_globals.h 
> >                 	zend_highlight.c zend_language_scanner.c 
> >                 	zend_language_scanner.h zend_language_scanner.l 
> >                 	zend_language_scanner_defs.h zend_multibyte.h 
> >   Log:
> >   implemented again zend-multibyte for PHP 5.3
> >   
> > 
> > 
> > ------------------------------------------------------------------------
> > 
> > This body part will be downloaded on demand.

-- 
Rui Hirokawa <[email protected]>


-- 
Zend Engine CVS Mailing List (http://cvs.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php