Re: cvs: ZendEngine2(PHP_5_2) / zend_operators.c

Pierre Joye <[email protected]> Tue, 17 Feb 2009 15:36:01 +0100

Newsgroups	gmane.comp.php.cvs.zend
Message-ID	<[email protected]>

hi Matt,

On Tue, Feb 17, 2009 at 3:16 PM, Matt Wilmas <[email protected]> wrote:

> @@ -936,7 +936,7 @@
>                return FAILURE;                 /* modulus by zero */
>        }
>
> -       if (abs(op2->value.lval) == 1) {
> +       if (op2->value.lval == -1) {
>                ZVAL_LONG(result, 0);
>                return SUCCESS;
>        }

Is it not changing the behavior? What happened when lval was 1? It
would be nice to have some tests too, if they do not exist already.

Cheers,
-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org

-- 
Zend Engine CVS Mailing List (http://cvs.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php