Re: [PHP-DEV] Suggest similar names for undefined function/method/class errors
"Sjoerd Langkemper" <[email protected]> Tue, 04 Aug 2026 09:55:27 +0200
| Newsgroups | gmane.comp.php.devel |
|---|---|
| Message-ID | <[email protected]> |
--510267bd9f782cec72c75ed940de7a4ceb5ec3d6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Jorg, On Tue, Aug 4, 2026, at 00:37, Jorg Sowa wrote: > =E2=80=9Cdid you mean =E2=80=A6?=E2=80=9D suggestions to errors for un= defined functions. While it does not change language semantics, it chang= es error messages and introduces additional checks on error paths, so I = would like to confirm whether consensus on the PR is sufficient or an RF= C is expected. >=20 Thanks, this is great. According to PHP Policy RFC: Exempt input type and value validation from= BC Break policy <https://wiki.php.net/rfc/policy-exempt-type-value-erro= r-bc-policy>, rephrasing error messages is not subject to the backwards = compatibility break policy. I think the amount of punctuation at the end is a bit much. Perhaps it w= ould be clearer (although less strictly correct) to say "(did you mean f= unc?)" instead of "(did you mean func()?)". But either way I am in favor= of this. Regards, Sjoerd Langkemper --510267bd9f782cec72c75ed940de7a4ceb5ec3d6 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html><html><head><title></title></head><body><div>Hello Jorg,<= /div><div><br></div><div>On Tue, Aug 4, 2026, at 00:37, Jorg Sowa wrote:= </div><blockquote type=3D"cite" id=3D"qt" style=3D""><div dir=3D"ltr"><d= iv><p class=3D"qt-gmail-isSelectedEnd"><span>=E2=80=9Cdid you mean =E2=80= =A6?=E2=80=9D suggestions to errors for undefined functions. While it do= es not change language semantics, it changes error messages and introduc= es additional checks on error paths, so I would like to confirm whether = consensus on the PR is sufficient or an RFC is expected.</span></p></div= ></div></blockquote><div><br></div><div>Thanks, this is great.</div><div= ><br></div><div>According to <a href=3D"https://wiki.php.net/rfc/policy-= exempt-type-value-error-bc-policy">PHP Policy RFC: Exempt input type and= value validation from BC Break policy</a>, rephrasing error messages is= not subject to the backwards compatibility break policy.</div><div><br>= </div><div>I think the amount of punctuation at the end is a bit much. P= erhaps it would be clearer (although less strictly correct) to say "(did= you mean func?)" instead of "(did you mean func()?)". But either way I = am in favor of this.<br></div><div><br></div><div>Regards,</div><div><br= ></div><div>Sjoerd Langkemper</div><div><br></div><div><br></div></body>= </html> --510267bd9f782cec72c75ed940de7a4ceb5ec3d6--