Re: First patch review - scoutapm PECL extension docs
James Titcumb <[email protected]>
| Newsgroups | gmane.comp.php.documentation.general |
|---|---|
| Message-ID | <CAF5o2a_oQjtF-uRdGUQAoXy6nd73554L1EcKLrZJWmc40aS3-Q@mail.gmail.com> |
Hi Christoph, On Mon, 30 Dec 2019, 18:39 Christoph M. Becker, <[email protected]> wrote: > > Great! I've just noticed that the "Resource Types" section is empty. > You could either insert &no.resource; there, or, in my opinion, just > drop that section. Yep, good call. I suggest to shorten the <refpurpose> of > scoutapm_get_calls(), and to move its current contents to the > description section; as it is now, it doesn't look neat: > <http://docs.php.net/manual/en/book.scoutapm.php>. > Yes that makes sense, I'll send a patch for these tweaks tomorrow. Thanks so much for the feedback, it's very helpful! Thanks James