Re: Getting started with improving the manual

Hi Jakob

Den søn. 17. maj 2020 kl. 19.17 skrev Jakob Givoni <[email protected]>:
> Let's start with the questions:
> - Can I pick any bug and submit a patch or should I only pick verified ones?

You can pick any non-assigned bugs to submit a patch for (or even
assigned ones if there has been no activity of the report in a while).

> - Is it possible to assign a bug first so two people don't waste time
> fixing the same one?

It is possible to assign bugs, but only to those with a VCS account
(technically we can assign to non VCS account holders but its not a
common thing).

> - If I have questions about how best to fix a bug, can I ask you guys
> here, or should we use comments in the bugs themselves?

This list is a good starting point to ask questions, and the only
official resource there is. There are third party chatrooms where you
can find some of the active contributors having out too, like room11
on StackOverflow.

> - There's a bug report on constants:
> https://bugs.php.net/bug.php?id=79141 - the conclusion is that the
> page on "constants" doesn't clarify that functions are not allowed in
> constant expressions, but actually,
> https://www.php.net/manual/en/language.constants.php doesn't even
> mention declaring constants using the "const" keyword. This
> information is on
> https://www.php.net/manual/en/language.oop5.constants.php which does
> say that function calls are not permitted. What is the fix here? Add
> explanation about "const" on the main "constants" page, or link to the
> class constants page?

The fix here would be to clarify the syntax on the page for constants
that the `const` keyword can be used however so with limitations vs
using the `define()` function. The object oriented documentation
should probably also have a similar note to state its limitations in
this context.

> Btw, why does a search on "const" not result in
> ANY matches?

The search feature of some of the manual entries have always been a
bit wonky, I can't remember where the indexing happens, as if its on
the PhD level or a cronjob which is apart of the `web/php.git`
repository that adds it to the dropdown, but looking for the code in
the actual website source is a start to trying to figure this one out.

-- 
regards,

Kalle Sommer Nielsen
[email protected]