Re: On removing PHP 5 docs (yes, I saw the previous thread)
"Christoph M. Becker" <[email protected]>
| Newsgroups | gmane.comp.php.documentation.general |
|---|---|
| Message-ID | <[email protected]> |
On 20.04.2020 at 07:40, Maciej Sobaczewski wrote: > W dniu 19.04.2020 o 16:38, Christoph M. Becker pisze: >> >> On 19.04.2020 at 07:56, Maciej Sobaczewski wrote: >> >>> I just noticed the question about removing PHP 5 docs and I was very >>> pleasantly surprised by Peter's and others approach to do so in a year. >>> >>> I'll just chim in and say that I had something similar on my mind and >>> one night when I was struggling from insomnia I already did a rather >>> significant portion of the removals on my fork's branch >>> >>> https://github.com/php/doc-en/compare/master...Sobak:experiment/remove-php5 >>> >>> >>> Then I thought that you guys are never ever going to accept that so >>> quickly and stopped but a really big part is already done. Soo... >>> you know, just ping me when the time will come :) I have some >>> experience from back then when I was removing PHP 4 bits so I >>> believe that I should be able to finish it in a reasonable time. >>> >>> I only want to believe that I'm right and rebasing it on top of >>> year's changes will not be _that_ hard :) >> >> Thanks for having already worked on this! Maybe it's worthwhile to >> provide a pull request, and mark it with the PHP 8.0 label (or similar)? > > I surely will, so that it doesn't disappear or get easily forgotten. > However, I would like to work on that a bit longer before opening > the PR, esp. now that I see there's a will and need for something > like that. > > I'm kind of git-pedant so I'd like to keep it clean and somehow > possible to review despite its gargantuic size (thus the commit > separation). > > I will work on that in the next week or two, probably doing a bit > more yet still not everything (my minimal plan is to finish the > changelogs and start removing inline mentions, we'll see how far > I can get with this). > > One request, though. Please let me know before this PR would be > merged. If I will not be responding in two or three days then sure, > go with it, it's open source after all :) But I would really appreciate > abbility to have a final glance and possibly improve some things before > this goes live. Some of the devs and doc people had just a discussion about starting to document PHP 8.0 as soon as possible, and I think it would be good to remove the PHP 5 specific documentation before adding PHP 8 specifics. Would you be still willing (and have the time) to proceed with the PHP 5 docs removal? Cheers, Christoph