Re: This PHP Manual build is broken

On 25.11.2020 at 03:36, Christopher Jones wrote:

> On 24/11/20 11:31 pm, Christopher Jones wrote:
>>
>> On 24/11/20 8:43 pm, Yoshinari Takaoka wrote:
>>> On Tue, 24 Nov 2020 09:46:41 +0100
>>> Andreas Heigl <[email protected]> wrote:
>>>
>>>> Hey List!
>>>>
>>>> That was not me! ;-)
>>>>
>>>> That is a "real" issue!
>>>
>>> Yes, real issue! I fixed it, maybe.
>>>
>>> https://urldefense.com/v3/__http://svn.php.net/viewvc?view=revision&revision=351568__;!!GqivPVa7Brio!Pq23PmhyfEGxO5XySTB1Xf31nRhcvyx_s-WuDFYf80T3ubKxh6aEVLpcLXwFq3htVbW-DA$
>>>
>>>
>>> ----
>>>
>>> It seems that this issue was caused by oci8 related id change.
>>>
>>> https://urldefense.com/v3/__https://github.com/php/doc-en/commit/0e0c883110b62cc4e5805696a56ff717f7088bfa__;!!GqivPVa7Brio!Pq23PmhyfEGxO5XySTB1Xf31nRhcvyx_s-WuDFYf80T3ubKxh6aEVLpcLXwFq3jvLNfu5w$
>>>
>>>
>>> Best Regards.
>>>
>> Yes it was me; thought it was due to a timing / commit change. My
>> local builds all went fine.
>>
>> I'll check the above commit in my morning tomorrow.
>>
>> CHris
>>
> That patch broke the OCI8 class names so I need to revert it.  I
> reverted locally and still didn't see any build breakage.  Do you know
> exactly what caused the build system to fail?
>
> The OCI-Lob and OCI-Collection classes necessarily got renamed
> <https://github.com/php/php-src/blob/PHP-8.0/UPGRADING#L401-L403> to
> OCILob and OCICollection in PHP 8.  My intent is just to document the
> latter names, and have notes that older PHP releases used the old
> names.  E.g like this doc
> <https://github.com/php/doc-en/commit/0e0c883110b62cc4e5805696a56ff717f7088bfa#diff-721eda1c783c04504a8bad4c13858ec911056cc8bd6d26e10eb7ceb81b516470R66-R74>.

From a quick look, the actual problem seems to be the renaming of

  &reference.oci8.OCI-Collection;
  &reference.oci8.OCI-Lob;

to

  &reference.oci8.OCICollection;
  &reference.oci8.OCILob;

The new names do not match the directory names, and as such the
directories would need to be renamed as well.

However, renaming files and xml:ids likely causes translation builds to
fail, and it may not be necessary at all.  Instead all occurrences of
"OCI-Lob" and "OCI-Collection" in the DocBook XML files need to be
replaced; except where the renaming is mentioned (and that should better
be put in a changelog entry instead of a note).

It might be best to have a PR (<https://github.com/php/doc-en/pulls>)
which is automatically build (albeit very slowly due to Travis' policy
change), and can be reviewed.

Christoph