Please stop anonymous login to edit.php.net

Done :)

From: Christoph M. Becker <[email protected]>
Date: Monday, 26 April 2021, 14:07
To: Sergey Panteleev <[email protected]>
Subject: Re: Please stop anonymous login to edit.php.net
Hi Sergey!

On 26.04.2021 at 12:48, Sergey Panteleev wrote:

> I'm now trying to implement the integration of Github and the editor,
> but I don’t yet understand how to do it correctly.
>
> At the moment, the patch can be downloaded as a .diff file and applied locally,
> how to send it to GitHub on behalf of the user without compromising security —
> I haven’t figured it out yet.

I don't think that makes sense.  Instead users should provide PRs in the
first place; the Github editor[1] makes that pretty easy (although it's
far from perfect for translation updates).

> Basically, the editor now works as a tool for tracking changes
> (as http://doc.php.net/revcheck.php doesn't work yet).
>
> If we disable the login for non-PHP users — is there any point then in the editor as such?

I heard that some translators prefer using edit.php.net, and I think
there is no reason to disallow that.  It is just that I feel we
shouldn't invite users to provide patches via edit.php.net, if we don't
address them, and GH PRs also have the advantage that anybody can easily
comment on a PR which appears to be helpful.  Furthermore, you can
subscribe to PRs or even the repo.

If you just forgot to sent the reply to the list, feel free to forward
my reply. :)

Cheers,
Christoph

[1]
<https://docs.github.com/en/github/managing-files-in-a-repository/editing-files-in-your-repository>