Re: PR with a test case for pear/OLE

Ken Guest <[email protected]> Fri, 6 Oct 2017 08:42:50 +0100
Newsgroups gmane.comp.php.pear.devel
Message-ID <CAKcc2m8Y1RV6BpgAhk3OsGLnM3pBDgK9qG4Sxw4-JCQiHwBTDw@mail.gmail.com>
Hi Alexy,

I did the following:

$ git clone [email protected]:sanmai/OLE.git
$ cd OLE
$ git merge origin/tests
$ composer  install
$ vendor/bin/phpunit

and it all looks good for me in relation to  running the tests :-)

Nice one

Ken


On 6 October 2017 at 02:23, Alexey Kopytko <[email protected]> wrote:
> Hello,
>
> If there's a chance to review and merge this PR, it would help much:
>
> https://github.com/pear/OLE/pull/9
>
> OLE still uses vars in classes - overdue to be refactored. Not the
> thing one wants to do without tests.
>
> I'm not asking for enabling Travis CI on this project, but that will
> be very welcome too.
>
> Thanks.
>
> -Alexey
>
> --
> PEAR Development Mailing List (http://pear.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php



-- 
http://about.me/kenguest/

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php