Re: Open Issue :: inactive...

Lukas Kahwe Smith <[email protected]> Tue, 16 Aug 2005 11:07:30 +0200
Newsgroups gmane.comp.php.pear.liveuser
Message-ID <[email protected]>
Lukas Kahwe Smith wrote:
> Jan Bolmeson wrote:
> 
>> Maybe just on my system due to my modifications but; since the 
>> is_active fix
>> users with is_active == 0 are able to log in...
>>
>> Could somebody verify?
> 
> 
> What backend are you using?
> I have a hunch that this is a DB backend problem ..
> Because in MDB/MDB2 it would be true not 0 ...

that was supposed to be false not true ..

anyways .. i did a search and found 2 locations where we were checking 
with === on is_active. back when we were still forcing the is_active to 
isActive mapping we ensure that even for DB the is_active field would 
also be cast to a boolean.

i just fixed those two in cvs ..
could someone with DB test this out?

please check if:
1) things work without an is_active field enabled in the config
2) if things work if its enabled and the user is_active, please also 
check getStatus()
2) if things work if its enabled and the user not is_active, please also 
check getStatus()

regards,
Lukas